[FW][FIX] packaging: more explicit debian control file #198473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Debian control file is used when installing Debian packages needed by Odoo by using the `debinstall.sh` script. On the other hand, when the Odoo Debian package is built, the Debian dependencies are also computed by the `dh_python3` script. So finally the real dependencies may differ. The main issue is `python3-gevent` which is missing in the control file. With this commit, the packages are explicitely declared in the control file instead of relying on incidentally installed packages. `python3-cryptography` is installed by `python3-openssl` `python3-idna` and `python3-urllib3` are installed by `python3-requests` `python3-markuosafe` is installed by `python3-jinja2` X-original-commit: f1fb052
|
|
|
@d-fence this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@d-fence ci/runbot failed on this forward-port PR |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2025
The Debian control file is used when installing Debian packages needed by Odoo by using the `debinstall.sh` script. On the other hand, when the Odoo Debian package is built, the Debian dependencies are also computed by the `dh_python3` script. So finally the real dependencies may differ. The main issue is `python3-gevent` which is missing in the control file. With this commit, the packages are explicitely declared in the control file instead of relying on incidentally installed packages. `python3-cryptography` is installed by `python3-openssl` `python3-idna` and `python3-urllib3` are installed by `python3-requests` `python3-markuosafe` is installed by `python3-jinja2` closes #198473 X-original-commit: f1fb052 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Debian control file is used when installing Debian packages needed by Odoo by using the
debinstall.shscript. On the other hand, when the Odoo Debian package is built, the Debian dependencies are also computed by thedh_python3script. So finally the real dependencies may differ.The main issue is
python3-geventwhich is missing in the control file.With this commit, the packages are explicitely declared in the control file instead of relying on incidentally installed packages.
python3-cryptographyis installed bypython3-opensslpython3-idnaandpython3-urllib3are installed bypython3-requestspython3-markupsafeis installed bypython3-jinja2Forward-Port-Of: #198102
Forward-Port-Of: #197302