Skip to content

[FW][PERF] point_of_sale: improve loading performance #198692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FW][PERF] point_of_sale: improve loading performance #198692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions addons/point_of_sale/static/src/app/models/related_models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export class Base extends WithLazyGetterTrap {
super({ traps });
this.model = model;
this._dynamicModels = dynamicModels;
this._indexMaps = {};
}
get models() {
return this.model.models;
Expand Down Expand Up @@ -205,12 +206,11 @@ export class Base extends WithLazyGetterTrap {
DATE_TIME_TYPE,
});
}
getCacheMap(fieldName) {
const cacheName = `_${fieldName}`;
if (!(cacheName in this)) {
this[cacheName] = new Map();
getIndexMaps(fieldName) {
if (!this._indexMaps[fieldName]) {
this._indexMaps[fieldName] = new Map();
}
return this[cacheName];
return this._indexMaps[fieldName];
}
get raw() {
return this._raw ?? {};
Expand Down Expand Up @@ -259,32 +259,37 @@ export function createRelatedModels(modelDefs, modelClasses = {}, opts = {}) {
return;
}

const cacheMap = record.getCacheMap(fieldName);
const indexMap = record.getIndexMaps(fieldName);
const key = database[item.model.name]?.key || "id";
const keyVal = item[key];
const existingIndex = indexMap.get(keyVal);

if (cacheMap.has(keyVal)) {
cacheMap.delete(keyVal);
const index = record[fieldName].findIndex((r) => r[key] === keyVal);
record[fieldName].splice(index, 1);
if (existingIndex !== undefined) {
indexMap.delete(keyVal);
record[fieldName].splice(existingIndex, 1);

// update indexes for items after existingIndex
for (let i = existingIndex; i < record[fieldName].length; i++) {
const shiftedItem = record[fieldName][i];
const shiftedKeyVal = shiftedItem[key];
indexMap.set(shiftedKeyVal, i);
}
}
}

function addItem(record, fieldName, item) {
const cacheMap = record.getCacheMap(fieldName);
const indexMap = record.getIndexMaps(fieldName);
const key = database[item.model.name]?.key || "id";
const keyVal = item[key];

if (!keyVal) {
console.warn(`Key ${key} not found in ${item.model.name}`);
}

if (!cacheMap.has(keyVal)) {
cacheMap.set(keyVal, item);
const existingIndex = indexMap.get(keyVal);
if (existingIndex === undefined) {
record[fieldName].push(item);
indexMap.set(keyVal, record[fieldName].length - 1);
} else {
const index = record[fieldName].findIndex((r) => r[key] === keyVal);
record[fieldName].splice(index, 1, item);
record[fieldName][existingIndex] = item;
}
}

Expand Down