[FW][FIX] im_livechat: ensure 'question selection' step has answers #198707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@akap-odoo @tsm-odoo this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@akap-odoo @tsm-odoo ci/runbot failed on this forward-port PR |
|
@robodoo r+ |
|
@akap-odoo you may want to rebuild or fix this PR as it has failed CI. |
Before this commit: It was possible to save a step with step_type "question selection" without any answers. However, this would cause an error when the bot was executed. After this commit: A constraint has been added to ensure that a "question selection" step cannot be saved without at least one answer. X-original-commit: c81d02e
akap-odoo
force-pushed
the
master-18.0-ensure-question-selection-has-answers-akap-417761-fw
branch
from
5f4b57f to
e7812e1
Compare
|
@akap-odoo @tsm-odoo this PR was modified / updated and has become a normal PR. It must be merged directly. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2025
Before this commit: It was possible to save a step with step_type "question selection" without any answers. However, this would cause an error when the bot was executed. After this commit: A constraint has been added to ensure that a "question selection" step cannot be saved without at least one answer. closes #198707 X-original-commit: c81d02e Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com> Signed-off-by: Akash Parmar (akap) <akap@odoo.com>
alexkuhn
deleted the
master-18.0-ensure-question-selection-has-answers-akap-417761-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior before PR:
It was possible to save a step with step_type "question selection" without any answers. However, this would cause an error when the bot was executed.
Desired behavior after PR is merged:
A constraint has been added to ensure that a "question selection" step cannot be saved without at least one answer.
task-id:4522835
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #198309
Forward-Port-Of: #197104