[FW][FIX] base_import: fix selector with an empty string #198937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - Install Accounting - On Accounting dashboard, click on "Import File" button of Bank journal - Select a CSV file with bank statements - On the left menu, select "No Separator" as "Thousands Separator" Issue: "Comma" is displayed as selected instead the first time. The second time "No Separator" stays as selected. However, the value sent when testing or importing is not the correct one. Cause: "No Separator" option should have an empty string as value. However, during the generation of the "select" element, the value for the "option" element is evaluated with: "opt.value or opt" As "opt.value" is the empty string (evaluated to False), "opt" is used instead, even if it is an object, which is not correct. The main issue is that the empty string is not handled as a valid value. Solution: Handle the empty string as an acceptable value. opw-4325310 X-original-commit: 4f8a6b4
|
|
|
@kitan191 @Julien00859 this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
|
@kitan191 @Julien00859 staging failed: ci/runbot on a70c4c7e854617eca974bad7d32453d161dd3cd0 (view more at https://runbot.odoo.com/runbot/build/75505221) |
|
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Feb 23, 2025
Steps to reproduce: - Install Accounting - On Accounting dashboard, click on "Import File" button of Bank journal - Select a CSV file with bank statements - On the left menu, select "No Separator" as "Thousands Separator" Issue: "Comma" is displayed as selected instead the first time. The second time "No Separator" stays as selected. However, the value sent when testing or importing is not the correct one. Cause: "No Separator" option should have an empty string as value. However, during the generation of the "select" element, the value for the "option" element is evaluated with: "opt.value or opt" As "opt.value" is the empty string (evaluated to False), "opt" is used instead, even if it is an object, which is not correct. The main issue is that the empty string is not handled as a valid value. Solution: Handle the empty string as an acceptable value. opw-4325310 closes #198937 X-original-commit: 4f8a6b4 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com> Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
xmo-odoo
deleted the
master-17.0-opw-4325310-fix_thousands_separator_import_bank_statement-pta-418135-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
"Comma" is displayed as selected instead the first time.
The second time "No Separator" stays as selected.
However, the value sent when testing or importing is not the correct one.
Cause:
"No Separator" option should have an empty string as value.
However, during the generation of the "select" element, the value for the "option" element is evaluated with:
opt.value or optAs
opt.valueis the empty string (evaluated to False),optis used instead, even if it is an object, which is not correct.The main issue is that the empty string is not handled as a valid value.
Solution:
Handle the empty string as an acceptable value.
opw-4325310
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #192536