[FW][IMP] hw_posbox_homepage: split rename and server dialogs #199327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@loouis-t @Ysoroko cherrypicking of pull request #198785 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
One single dialog was used to change the IoT Box hostname and connect it to a database. These dialogs have been splitted. Additionnaly, the hostname update is now performed through python instead of bash.
Each dialog had different button colors, positions, input placholders or labels. They now follow the same logic: placeholders and buttons in footer.
loouis-t
force-pushed
the
saas-18.2-saas-18.1-hw_posbox_homepage-split-rename-and-server-lotr-417905-fw
branch
from
40665c5 to
ba7178b
Compare
|
@robodoo r+ |
|
@odoo/rd-security hello security team, could you override this forward port please? (Here is the last override reason) |
|
@robodoo override=ci/security |
robodoo
pushed a commit
that referenced
this pull request
Feb 26, 2025
One single dialog was used to change the IoT Box hostname and connect it to a database. These dialogs have been splitted. Additionnaly, the hostname update is now performed through python instead of bash. Part-of: #199327 Signed-off-by: Yaroslav Soroko (yaso) <yaso@odoo.com> Signed-off-by: Louis Travaux (lotr) <lotr@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Feb 26, 2025
Each dialog had different button colors, positions, input placholders or labels. They now follow the same logic: placeholders and buttons in footer. closes #199327 Signed-off-by: Yaroslav Soroko (yaso) <yaso@odoo.com> Signed-off-by: Louis Travaux (lotr) <lotr@odoo.com>
xmo-odoo
deleted the
saas-18.2-saas-18.1-hw_posbox_homepage-split-rename-and-server-lotr-417905-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One single dialog was used to change the IoT Box hostname and connect it to a database.
These dialogs have been splitted.
Additionnaly, the hostname update is now performed through python instead of bash.
Forward-Port-Of: #198785