[FW][FIX] website_sale: use correct limit when filtering newest products

[fw-bot]

Versions

• saas-17.4+

Steps

1. Create a new product with a lot of variants;
2. publish it to the website;
3. edit the website home page to add a product carousel;
4. set it to display newest products & hide variants.

Issue

Fewer than 16 products are displayed in the carousel.

Cause

Unlike the other product filters handled in #189040, the "Newest Products" filter is defined in data/data.xml, and stored as a record.

This means it doesn't use the _get_products method to perform the search, instead using the _prepare_values method from the website module.

For obvious reasons, the method defined in website doesn't take the hide_variants parameter into account to get the correct amount of search results:

odoo/addons/website/models/website_snippet_filter.py

Lines 102 to 108 in 0f64298

	try:
	records = self.env[filter_sudo.model_id].sudo(False).with_context(**literal_eval(filter_sudo.context)).search(
	domain,
	order=','.join(literal_eval(filter_sudo.sort)) or None,
	limit=limit
	)
	return self._filter_records_to_values(records)

Instead it passes 16 product.product records to the _filter_records_to_values override in website_sale, where duplicate templates are filtered out, resulting in fewer than 16 product templates:

odoo/addons/website_sale/models/website_snippet_filter.py

Lines 73 to 76 in 0f64298

	def _filter_records_to_values(self, records, is_sample=False):
	hide_variants = self.env.context.get('hide_variants') and not isinstance(records, list)
	if hide_variants:
	records = records.product_tmpl_id

Solution

When calling super()._prepare_values for stored product.product filters, temporarily square the usual limit for the search, and filter reduce to size later.

This may still be inadequate when working with products with dozens of variants, but should cover most normal use cases without requiring drastic changes to filter templates or search domain in stable.

On master, we could add a new filter specifically for product.template.

opw-4302856

Forward-Port-Of: #195857

[robodoo]

[fw-bot]

This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[fw-bot]

@lvsz @Feyensv ci/runbot failed on this forward-port PR

[fw-bot]

@lvsz @Feyensv this PR was modified / updated and has become a normal PR. It must be merged directly.

[lvsz]

robodoo r+

[robodoo]

@lvsz @Feyensv 'ci/runbot' failed on this reviewed PR.

[lvsz]

robodoo r+

[robodoo]

@lvsz @Feyensv staging failed: ci/runbot on 229139cf9f6b4c787b799b49f0961107470d8592 (view more at https://runbot.odoo.com/runbot/build/75870818)

[lvsz]

robodoo retry