[FW][PERF] point_of_sale: improve loading performance #199745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, loading the PoS with several products was slow due to inefficient data handling. The `addItem` function operated in O(n) time and, because it was called repeatedly over datasets, this led to major performance issues. After this commit, `addItem` now runs in O(1) by using a map/dictionary approach. This significantly reduces loading times for PoS when many products are present. opw-4584930 X-original-commit: 8831add
|
|
|
@pedrambiria @caburj this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
|
@pedrambiria @caburj 'ci/runbot' failed on this reviewed PR. |
|
robodoo retry |
|
@pedrambiria retry makes no sense when the PR is not in error. |
robodoo
pushed a commit
that referenced
this pull request
Feb 28, 2025
Before this commit, loading the PoS with several products was slow due to inefficient data handling. The `addItem` function operated in O(n) time and, because it was called repeatedly over datasets, this led to major performance issues. After this commit, `addItem` now runs in O(1) by using a map/dictionary approach. This significantly reduces loading times for PoS when many products are present. opw-4584930 closes #199745 X-original-commit: 8831add Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com> Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, loading the PoS with several products was slow due to inefficient data handling. The
addItemfunction operated in O(n) time and, because it was called repeatedly over datasets, this led to major performance issues.After this commit,
addItemnow runs in O(1) by using a map/dictionary approach. This significantly reduces loading times for PoS when many products are present.opw-4584930
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #198692
Forward-Port-Of: #198123