[FW][FIX] html_editor: add missing checklist styles in html_editor
#200477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem**: When a portal user edits a task's description and adds a checklist, the checkboxes do not appear as they do in the Odoo backend (e.g., in the To-Do app). This occurs because the editor is rendered in an `iframe` with only `html_editor` loaded, while checklist styles are in `web_editor`. **Solution**: Add checklist styles to `html_editor`. **Steps to Reproduce**: 1. Share a project with **"Edit"** permission for a portal user. 2. Log in as the portal user. 3. Go to any task inside the project. 4. In the description, add a checklist using `/checklist` command. - **Issue**: No checkboxes appear. opw-4481993 X-original-commit: ec6d26f
**Problem**: When a portal user edits a task's description, focusing on the editable shows an outline. This occurs because the editor is rendered in an `iframe` with only `html_editor` loaded, while styles are in `web_editor`. **Solution**: Add `contenteditable` styles to `html_editor`. **Steps to Reproduce**: 1. Share a project with **"Edit"** permission for a portal user. 2. Log in as the portal user. 3. Go to any task inside the project. - **Issue**: Editable has black border on hover. opw-4481993 X-original-commit: 559f8d8
|
|
|
@walidsahli @dmo-odoo this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2025
**Problem**: When a portal user edits a task's description and adds a checklist, the checkboxes do not appear as they do in the Odoo backend (e.g., in the To-Do app). This occurs because the editor is rendered in an `iframe` with only `html_editor` loaded, while checklist styles are in `web_editor`. **Solution**: Add checklist styles to `html_editor`. **Steps to Reproduce**: 1. Share a project with **"Edit"** permission for a portal user. 2. Log in as the portal user. 3. Go to any task inside the project. 4. In the description, add a checklist using `/checklist` command. - **Issue**: No checkboxes appear. opw-4481993 X-original-commit: ec6d26f Part-of: #200477 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Walid Sahli (wasa) <wasa@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2025
**Problem**: When a portal user edits a task's description, focusing on the editable shows an outline. This occurs because the editor is rendered in an `iframe` with only `html_editor` loaded, while styles are in `web_editor`. **Solution**: Add `contenteditable` styles to `html_editor`. **Steps to Reproduce**: 1. Share a project with **"Edit"** permission for a portal user. 2. Log in as the portal user. 3. Go to any task inside the project. - **Issue**: Editable has black border on hover. opw-4481993 closes #200477 X-original-commit: 559f8d8 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Walid Sahli (wasa) <wasa@odoo.com>
xmo-odoo
deleted the
master-18.0-opw-4481993-add_missing_css_in_html_editor-wasa-420747-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a portal user edits a task's description and adds a checklist, the checkboxes do not appear as they do in the Odoo backend (e.g., in the To-Do app).
This occurs because the editor is rendered in an
iframewith onlyhtml_editorloaded, while checklist styles are inweb_editor.Solution:
Add checklist styles to
html_editor.Steps to Reproduce:
/checklistcommand.opw-4481993
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #200309