[FW][FIX] portal: correct avatar ratio in portal chatter #200486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, some messages in portal chatter may have avatar squished vertically or horizontally when the source image of avatar is not a square. This happens because avatar are cropped to fit cover with `.o_object_fit_cover`, in order to give the right visual when the avatar doesn't fit in a square. The classname was present but the SCSS file defining this rule was missing from the ` "portal.assets_chatter_style"` bundle, which this commit fixes. X-original-commit: 43c9b7f
|
|
|
@alexkuhn this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2025
Before this commit, some messages in portal chatter may have avatar squished vertically or horizontally when the source image of avatar is not a square. This happens because avatar are cropped to fit cover with `.o_object_fit_cover`, in order to give the right visual when the avatar doesn't fit in a square. The classname was present but the SCSS file defining this rule was missing from the ` "portal.assets_chatter_style"` bundle, which this commit fixes. closes #200486 X-original-commit: 43c9b7f Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
alexkuhn
deleted the
master-18.0-portal-chatter-avatar-object-fit-cover-aku-420773-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, some messages in portal chatter may have avatar squished vertically or horizontally when the source image of avatar is not a square.
This happens because avatar are cropped to fit cover with
.o_object_fit_cover, in order to give the right visual when the avatar doesn't fit in a square. The classname was present but the SCSS file defining this rule was missing from the"portal.assets_chatter_style"bundle, which this commit fixes.Before
After
Forward-Port-Of: #200241