[IMP] point_of_sale: remove customer display configuration #201637

jipr-odoo · 2025-03-13T17:39:36Z

Before this commit:

Customer display configuration included three options: local, remote, and proxy,
making the setup more complex.

After this commit:

Customer display is now always enabled by default, removing the need for
configuration in res config settings. This simplifies the setup and ensures
the feature is always available.

Task-4604770

Related Enterprise PR:https://github.com/odoo/enterprise/pull/81395
Related Upgrade PR:https://github.com/odoo/upgrade/pull/7386

robodoo · 2025-03-13T17:39:40Z

addons/point_of_sale/models/pos_config.py

addons/point_of_sale/static/src/app/components/navbar/navbar.xml

addons/point_of_sale/static/src/customer_display/customer_display_adapter.js

addons/point_of_sale/static/tests/generic_helpers/offline_util.js

vlst-odoo · 2025-04-09T11:27:46Z

as i understand, one of the goals of the task was to be able to use the customer display even if the same config is used on different devices, i.e.:

Open config 1 on device A;
Open config 1 on device B;
Open customer display on device A;
1. Open customer display on device B;
Add a line to the order on device A;
Observe that the line is shown on the customer display on device A and not B;

Is this not the case ?

If it is indeed, then you can do this in a different commit

addons/point_of_sale/__manifest__.py

addons/point_of_sale/controllers/customer_display.py

addons/point_of_sale/static/src/app/customer_display/customer_display_qr_code_popup.js

addons/point_of_sale/static/src/app/components/navbar/navbar.js

addons/point_of_sale/static/src/app/customer_display/customer_display_qr_code_popup.xml

Before this commit: ===================== Customer display configuration included three options: local, remote, and proxy, making the setup more complex. After this commit: ================ Customer display is now always enabled by default, removing the need for configuration in res config settings. This simplifies the setup and ensures the feature is always available. Task-4604770 Related Enterprise PR:odoo/enterprise#81395 Related Upgrade PR:odoo/upgrade#7386

In this commit: ================ Moved the customer_display_adapter file from the customer_display folder to pos/app/customer_display because it contains logic that is directly used by the POS app. The principle is to keep all code used by the POS app within the pos/app directory. This change helps maintain a consistent structure where all dependencies used in POS are centralized in its app directory.

…uuid In this commit: ================ - Implemented support for customer display on a per-device basis using `device_uuid`. - Customer display will now run per POS config session based on the device, ensuring each device maintains its own independent display. Ex: - Open POS Config 1 on Device A. - Open the same POS Config 1 on Device B. - Start the customer display on both devices. - Add a product line to the order on Device A. - `The line will appear only on the customer display linked to Device A not Device B.` - Added a popup for small devices to display a QR code and link for the customer display. - The QR/link can be scanned or copied to run the POS and customer display on separate devices easily. Task-4604770

…atus In this commit: ================== The use_proxy getter method was incorrectly referenced, while the actual method name was useProxy. This mismatch prevented the UI from displaying the correct status of the proxy customer display. Updated the reference to use the correct method name.

vlst-odoo

robodoo rebase-ff r+

robodoo · 2025-04-16T12:28:11Z

Merge method set to rebase and fast-forward.

Before this commit: ===================== Customer display configuration included three options: local, remote, and proxy, making the setup more complex. After this commit: ================ Customer display is now always enabled by default, removing the need for configuration in res config settings. This simplifies the setup and ensures the feature is always available. Task-4604770 Related Enterprise PR:odoo/enterprise#81395 Related Upgrade PR:odoo/upgrade#7386 Part-of: #201637 Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>

In this commit: ================ Moved the customer_display_adapter file from the customer_display folder to pos/app/customer_display because it contains logic that is directly used by the POS app. The principle is to keep all code used by the POS app within the pos/app directory. This change helps maintain a consistent structure where all dependencies used in POS are centralized in its app directory. Part-of: #201637 Related: odoo/enterprise#81395 Related: odoo/upgrade#7386 Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>

…uuid In this commit: ================ - Implemented support for customer display on a per-device basis using `device_uuid`. - Customer display will now run per POS config session based on the device, ensuring each device maintains its own independent display. Ex: - Open POS Config 1 on Device A. - Open the same POS Config 1 on Device B. - Start the customer display on both devices. - Add a product line to the order on Device A. - `The line will appear only on the customer display linked to Device A not Device B.` - Added a popup for small devices to display a QR code and link for the customer display. - The QR/link can be scanned or copied to run the POS and customer display on separate devices easily. Task-4604770 Part-of: #201637 Related: odoo/enterprise#81395 Related: odoo/upgrade#7386 Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>

…atus In this commit: ================== The use_proxy getter method was incorrectly referenced, while the actual method name was useProxy. This mismatch prevented the UI from displaying the correct status of the proxy customer display. Updated the reference to use the correct method name. closes #201637 Related: odoo/enterprise#81395 Related: odoo/upgrade#7386 Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch from 11b11e8 to ef49de6 Compare March 13, 2025 17:47

C3POdoo added the RD research & development, internal work label Mar 13, 2025

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch from ef49de6 to 660869d Compare March 24, 2025 05:47

paso-odoo requested changes Mar 24, 2025

View reviewed changes

addons/point_of_sale/models/pos_config.py Outdated Show resolved Hide resolved

addons/point_of_sale/models/pos_config.py Outdated Show resolved Hide resolved

addons/point_of_sale/models/pos_config.py Outdated Show resolved Hide resolved

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch 2 times, most recently from 1062843 to cd72e3b Compare March 24, 2025 11:01

jipr-odoo marked this pull request as ready for review March 26, 2025 10:51

C3POdoo requested review from a team and vlst-odoo and removed request for a team March 26, 2025 10:55

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch from cd72e3b to 11faaa9 Compare March 26, 2025 10:55

vlst-odoo requested changes Mar 26, 2025

View reviewed changes

addons/point_of_sale/models/pos_config.py Outdated Show resolved Hide resolved

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch 2 times, most recently from 61d4590 to 9d40845 Compare April 1, 2025 04:59

vlst-odoo reviewed Apr 2, 2025

View reviewed changes

addons/point_of_sale/static/src/app/components/navbar/navbar.xml Outdated Show resolved Hide resolved

vlst-odoo reviewed Apr 2, 2025

View reviewed changes

addons/point_of_sale/static/src/customer_display/customer_display_adapter.js Outdated Show resolved Hide resolved

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch 5 times, most recently from fe79006 to 618130c Compare April 4, 2025 12:50

jipr-odoo changed the title ~~[IMP] point_of_sale: simplify customer display settings~~ [IMP] point_of_sale: remove customer display configuration Apr 4, 2025

vlst-odoo reviewed Apr 8, 2025

View reviewed changes

addons/point_of_sale/static/tests/generic_helpers/offline_util.js Outdated Show resolved Hide resolved

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch 4 times, most recently from 6111503 to c0f9f6f Compare April 9, 2025 08:55

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch 2 times, most recently from b607875 to 65fd6d5 Compare April 11, 2025 12:47

vlst-odoo reviewed Apr 11, 2025

View reviewed changes

addons/point_of_sale/__manifest__.py Outdated Show resolved Hide resolved

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch 3 times, most recently from ba18c58 to 2beb82d Compare April 15, 2025 06:54

vlst-odoo reviewed Apr 15, 2025

View reviewed changes

addons/point_of_sale/controllers/customer_display.py Outdated Show resolved Hide resolved

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch from 2beb82d to 8f39f9a Compare April 15, 2025 08:42

vlst-odoo reviewed Apr 15, 2025

View reviewed changes

addons/point_of_sale/static/src/app/customer_display/customer_display_qr_code_popup.js Outdated Show resolved Hide resolved

vlst-odoo reviewed Apr 15, 2025

View reviewed changes

addons/point_of_sale/static/src/app/components/navbar/navbar.js Outdated Show resolved Hide resolved

vlst-odoo reviewed Apr 15, 2025

View reviewed changes

jipr-odoo added 4 commits April 15, 2025 18:38

jipr-odoo force-pushed the master-pos-simplify-customer-display-settings-imp-jipr branch from 8f39f9a to f2d0e58 Compare April 15, 2025 13:09

vlst-odoo reviewed Apr 16, 2025

View reviewed changes

robodoo added the 18.3 label Apr 16, 2025

robodoo temporarily deployed to merge April 16, 2025 19:58 Inactive

robodoo closed this Apr 16, 2025

fw-bot deleted the master-pos-simplify-customer-display-settings-imp-jipr branch April 23, 2025 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[IMP] point_of_sale: remove customer display configuration #201637

[IMP] point_of_sale: remove customer display configuration #201637

Uh oh!

jipr-odoo commented Mar 13, 2025 •

edited

Loading

Uh oh!

robodoo commented Mar 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlst-odoo commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlst-odoo left a comment

Uh oh!

robodoo commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[IMP] point_of_sale: remove customer display configuration #201637

[IMP] point_of_sale: remove customer display configuration #201637

Uh oh!

Conversation

jipr-odoo commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before this commit:

After this commit:

Uh oh!

robodoo commented Mar 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlst-odoo commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlst-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

robodoo commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jipr-odoo commented Mar 13, 2025 •

edited

Loading