[FIX] google_account, google_calendar: use google_account for calendar sync #201702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r sync
Before this commit, the `refresh_token` handling was done in the `calendar`
module, even though it relates to token management and should therefore be
handled by `google_account`, which manages tokens and requests to Google.
This also fixes the call to `get_param('google_calendar_client_secret')`,
which should use the correct helper `_get_client_secret`, as it may be
monkey-patched by another module.
|
|
geflx
approved these changes
Mar 14, 2025
|
@robodoo r+ |
This was referenced Mar 17, 2025
omar-sherif9992
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 26, 2025
…r sync
Before this commit, the `refresh_token` handling was done in the `calendar`
module, even though it relates to token management and should therefore be
handled by `google_account`, which manages tokens and requests to Google.
This also fixes the call to `get_param('google_calendar_client_secret')`,
which should use the correct helper `_get_client_secret`, as it may be
monkey-patched by another module.
closes odoo#201702
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 27, 2025
…r sync
Before this commit, the `refresh_token` handling was done in the `calendar`
module, even though it relates to token management and should therefore be
handled by `google_account`, which manages tokens and requests to Google.
This also fixes the call to `get_param('google_calendar_client_secret')`,
which should use the correct helper `_get_client_secret`, as it may be
monkey-patched by another module.
closes odoo/odoo#201702
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
arj-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 2, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also odoo#201702 task-4653852
robodoo
pushed a commit
that referenced
this pull request
Apr 3, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also #201702 task-4653852 closes #202309 Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
nikj-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 3, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also odoo#201702 task-4653852 X-original-commit: 84998fa
robodoo
pushed a commit
that referenced
this pull request
Apr 4, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also #201702 task-4653852 closes #204619 X-original-commit: 84998fa Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 4, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also odoo#201702 task-4653852 X-original-commit: 06f0add
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 4, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also odoo#201702 task-4653852 X-original-commit: 06f0add
robodoo
pushed a commit
that referenced
this pull request
Apr 7, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also #201702 task-4653852 closes #204897 X-original-commit: 06f0add Signed-off-by: Arnaud Joset (arj) <arj@odoo.com> Signed-off-by: Nikhil Joshi (nikj) <nikj@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 7, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also #201702 task-4653852 closes #204899 X-original-commit: 06f0add Signed-off-by: Arnaud Joset (arj) <arj@odoo.com> Signed-off-by: Nikhil Joshi (nikj) <nikj@odoo.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Apr 26, 2025
…r calendar Before this commit, the refresh_token handling was done in the calendar module, even though it relates to token management and should therefore be handled by microsoft_account, which manages tokens and requests to Google. See also odoo/odoo#201702 task-4653852 closes odoo/odoo#202309 Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the
refresh_tokenhandling was done in thecalendarmodule, even though it relates to token management and should therefore be
handled by
google_account, which manages tokens and requests to Google.This also fixes the call to
get_param('google_calendar_client_secret'), which should use the correct helper_get_client_secret, as it may be monkey-patched by another module.