[FW][FIX] pos wallet: show all customers wallets on search pos #202204
Conversation
|
|
|
This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@marh-odoo @adgu-odoo this forward port of #199907 is awaiting action (not merged or closed). |
fw-bot
force-pushed
the
saas-18.2-18.0-fix-4572808-marh-423627-fw
branch
from
c164f5f to
5626df0
Compare
|
@marh-odoo @adgu-odoo legal/cla failed on this forward-port PR |
fw-bot
force-pushed
the
saas-18.2-18.0-fix-4572808-marh-423627-fw
branch
from
5626df0 to
a105cae
Compare
When you have many contacts (more than 300 approx.) and you search for a specific one from the point of sale, if more than one of those listed in the result has a wallet, only one wallet will be shown, because by default fetchCoupons has limit = 1 Video on runbot: https://drive.google.com/file/d/1kFAYjxWJmTNuNOK2ul684x_H_GAptsjB/view?usp=sharing By modifying searchPartner function, we ensure all customers wallets will be displayed, I've also added point condition to ensure not to show empty wallets. Related task: [4572808](https://www.odoo.com/odoo/project/49/tasks/4572808) X-original-commit: b621b25
fw-bot
force-pushed
the
saas-18.2-18.0-fix-4572808-marh-423627-fw
branch
from
a105cae to
e5c3fae
Compare
|
@marh-odoo @adgu-odoo child PR #202212 was modified / updated and has become a normal PR. This PR (and any of its parents) will need to be merged independently as approvals won't cross. |
|
@marh-odoo @adgu-odoo this forward port of #199907 is awaiting action (not merged or closed). |
3 similar comments
|
@marh-odoo @adgu-odoo this forward port of #199907 is awaiting action (not merged or closed). |
|
@marh-odoo @adgu-odoo this forward port of #199907 is awaiting action (not merged or closed). |
|
@marh-odoo @adgu-odoo this forward port of #199907 is awaiting action (not merged or closed). |
|
robodoo r+ |
|
@marh-odoo @adgu-odoo because this PR has multiple commits, I need to know how to merge it:
|
When you have many contacts (more than 300 approx.) and you search for a specific one from the point of sale, if more than one of those listed in the result has a wallet, only one wallet will be shown, because by default fetchCoupons has limit = 1 Video on runbot: https://drive.google.com/file/d/1kFAYjxWJmTNuNOK2ul684x_H_GAptsjB/view?usp=sharing By modifying searchPartner function, we ensure all customers wallets will be displayed, I've also added point condition to ensure not to show empty wallets. Related task: [4572808](https://www.odoo.com/odoo/project/49/tasks/4572808) closes #202204 X-original-commit: b621b25 Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
5 participants
Show all customers wallets on search pos
Impacted versions:
18.0 and later
Steps to reproduce:
Add more than one customer with same first characters of their name
Add gift cards to them with positive balance
Search them by clicking customer button on a pos session
Video on runbot: https://drive.google.com/file/d/1kFAYjxWJmTNuNOK2ul684x_H_GAptsjB/view?usp=sharing
Current behavior:
Only shows the first wallet found (fetchCoupons default limit 1)
Expected behavior:
Show all wallets
Task: 4572808
Forward-Port-Of: #199907