[FW][FIX] phone_validation: phone numbers in mexico #202295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robodoo
added
forwardport
|
@ande-odoo @tde-banana-odoo cherrypicking of pull request #197838 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Current behaviour: Mexican phone numbers are not managed correctly following the 2019 changes in Mexico. (Removing a 1 in phone numbers) Cause of the issue: The phonenumbers library removing support of mexican phone numbers starting with 1 in 8.13.38 The Whatsapp API still using the mexican phone numbers starting with 1 Fixes: Patched the phonenumbers library, removing 1 at the right place for mexican phone numbers. Similar to: odoo@53885e4 Changed the forcing to international format when parsing, to make sure the patches are applied before detecting an issue. Similar to: odoo@29a4de8 opw-4473528 X-original-commit: 8452b3a
ande-odoo
force-pushed
the
18.0-17.0-OPW_4473528-phone_validation-mexican_phone_numbers-ande-423732-fw
branch
from
253e478 to
5a68f39
Compare
|
@robodoo r+ |
This was referenced Mar 19, 2025
omar-sherif9992
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 26, 2025
Current behaviour: Mexican phone numbers are not managed correctly following the 2019 changes in Mexico. (Removing a 1 in phone numbers) Cause of the issue: The phonenumbers library removing support of mexican phone numbers starting with 1 in 8.13.38 The Whatsapp API still using the mexican phone numbers starting with 1 Fixes: Patched the phonenumbers library, removing 1 at the right place for mexican phone numbers. Similar to: odoo@53885e4 Changed the forcing to international format when parsing, to make sure the patches are applied before detecting an issue. Similar to: odoo@29a4de8 opw-4473528 closes odoo#202295 X-original-commit: 8452b3a Related: odoo/enterprise#81677 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> Signed-off-by: Antoine Demany (ande) <ande@odoo.com>
fw-bot
deleted the
18.0-17.0-OPW_4473528-phone_validation-mexican_phone_numbers-ande-423732-fw
branch
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 27, 2025
Current behaviour: Mexican phone numbers are not managed correctly following the 2019 changes in Mexico. (Removing a 1 in phone numbers) Cause of the issue: The phonenumbers library removing support of mexican phone numbers starting with 1 in 8.13.38 The Whatsapp API still using the mexican phone numbers starting with 1 Fixes: Patched the phonenumbers library, removing 1 at the right place for mexican phone numbers. Similar to: odoo/odoo@53885e4 Changed the forcing to international format when parsing, to make sure the patches are applied before detecting an issue. Similar to: odoo/odoo@29a4de8 opw-4473528 closes odoo/odoo#202295 X-original-commit: 8452b3ae74450010cbcd6b84df4b4a4dea6d8380 Related: odoo/enterprise#81677 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> Signed-off-by: Antoine Demany (ande) <ande@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour:
Mexican phone numbers are not managed correctly following the 2019 changes in Mexico.
(Removing a 1 in phone numbers)
Cause of the issue:
The phonenumbers library removing support of mexican phone numbers starting with 1 in 8.13.38
The Whatsapp API still using the mexican phone numbers starting with 1
Fixes:
Patched the phonenumbers library, removing 1 at the right place for mexican phone numbers.
Similar to: 53885e4
Changed the forcing to international format when parsing, to make sure the patches are applied before detecting an issue.
Similar to: 29a4de8
opw-4473528
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #197838