[FW][FIX] point_of_sale: proper handling of caba taxes #202308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robodoo
added
forwardport
|
@svfu-odoo @oco-odoo cherrypicking of pull request #201812 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
svfu-odoo
force-pushed
the
saas-17.4-16.0-fix_caba_pos_tax_report-svfu-423747-fw
branch
from
575f3e7 to
a5e77f0
Compare
C3POdoo
requested review from
a team and
vlst-odoo
and removed request for
a team
We do not create create caba moves anymore for PoS session closing moves. (See commits 2f62d5c and 66e3696) But now there are 2 issues when using (only) caba taxes in a PoS session. (1) The closing move does not appear on the tax report. (2) The closing move line do not get the right tax tags (they do not have any). Issue (1) is solved by making pos closing moves `always_tax_exigible`. (In case they did not creat cash basis entries; for backwards compatibility). Issue (2) is solved by telling the tax computation for the lines to include caba taxes (instead of just changing the account to be the "final" account and not the caba transition account). opw-4355124 X-original-commit: 8f388be
svfu-odoo
force-pushed
the
saas-17.4-16.0-fix_caba_pos_tax_report-svfu-423747-fw
branch
from
a5e77f0 to
88d76dd
Compare
smetl
approved these changes
Mar 19, 2025
robodoo
pushed a commit
that referenced
this pull request
Mar 19, 2025
We do not create create caba moves anymore for PoS session closing moves. (See commits 2f62d5c and 66e3696) But now there are 2 issues when using (only) caba taxes in a PoS session. (1) The closing move does not appear on the tax report. (2) The closing move line do not get the right tax tags (they do not have any). Issue (1) is solved by making pos closing moves `always_tax_exigible`. (In case they did not creat cash basis entries; for backwards compatibility). Issue (2) is solved by telling the tax computation for the lines to include caba taxes (instead of just changing the account to be the "final" account and not the caba transition account). opw-4355124 closes #202308 X-original-commit: 8f388be Related: odoo/enterprise#81685 Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Signed-off-by: Laurent Smet (las) <las@odoo.com>
fw-bot
deleted the
saas-17.4-16.0-fix_caba_pos_tax_report-svfu-423747-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not create create caba moves anymore for PoS session closing moves.
(See commits 2f62d5c and 66e3696)
But now there are 2 issues when using (only) caba taxes in a PoS session.
(1) The closing move does not appear on the tax report.
(2) The closing move line do not get the right tax tags (they do not have any).
Issue (1) is solved by making pos closing moves
always_tax_exigible.(In case they did not creat cash basis entries; for backwards compatibility).
Issue (2) is solved by telling the tax computation for the lines to include caba taxes
(instead of just changing the account to be the "final" account and not
the caba transition account).
opw-4355124
Forward-Port-Of: #201812