[FW][FIX] point_of_sale: proper handling of caba taxes #202621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not create create caba moves anymore for PoS session closing moves. (See commits 2f62d5c and 66e3696) But now there are 2 issues when using (only) caba taxes in a PoS session. (1) The closing move does not appear on the tax report. (2) The closing move line do not get the right tax tags (they do not have any). Issue (1) is solved by making pos closing moves `always_tax_exigible`. (In case they did not creat cash basis entries; for backwards compatibility). Issue (2) is solved by telling the tax computation for the lines to include caba taxes (instead of just changing the account to be the "final" account and not the caba transition account). opw-4355124 X-original-commit: 3b57ea9
|
|
|
This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Mar 20, 2025
We do not create create caba moves anymore for PoS session closing moves. (See commits 2f62d5c and 66e3696) But now there are 2 issues when using (only) caba taxes in a PoS session. (1) The closing move does not appear on the tax report. (2) The closing move line do not get the right tax tags (they do not have any). Issue (1) is solved by making pos closing moves `always_tax_exigible`. (In case they did not creat cash basis entries; for backwards compatibility). Issue (2) is solved by telling the tax computation for the lines to include caba taxes (instead of just changing the account to be the "final" account and not the caba transition account). opw-4355124 closes #202621 X-original-commit: 3b57ea9 Related: odoo/enterprise#81803 Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Signed-off-by: Laurent Smet (las) <las@odoo.com>
fw-bot
deleted the
saas-18.2-16.0-fix_caba_pos_tax_report-svfu-424258-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not create create caba moves anymore for PoS session closing moves.
(See commits 2f62d5c and 66e3696)
But now there are 2 issues when using (only) caba taxes in a PoS session.
(1) The closing move does not appear on the tax report.
(2) The closing move line do not get the right tax tags (they do not have any).
Issue (1) is solved by making pos closing moves
always_tax_exigible.(In case they did not creat cash basis entries; for backwards compatibility).
Issue (2) is solved by telling the tax computation for the lines to include caba taxes
(instead of just changing the account to be the "final" account and not
the caba transition account).
opw-4355124
Forward-Port-Of: #202479
Forward-Port-Of: #201812