Skip to content

Conversation

alexkuhn
Copy link
Contributor

@alexkuhn alexkuhn commented Mar 21, 2025

The composer should not send the current input on Enter key when being on a mobile device, since it is impossible for them to create a new line with either ctrl-Enter or alt-enter.

[FIX] mail: Discuss on Mobile - Enter key behavior

The composer should not send the current input on Enter key when being on a mobile device, since it is impossible for them to create a new line with either ctrl-Enter or alt-enter.

The style of send button in mobile was too subtle between active and inactive. Since this button becomes the only way to send message in mobile, its visual as been adapted to make it more obvious.

Task-4209142

Before / After (visual)
Screenshot 2025-03-21 at 14 20 39
Screenshot 2025-03-21 at 14 20 02

@robodoo
Copy link
Contributor

robodoo commented Mar 21, 2025

Pull request status dashboard

@alexkuhn
Copy link
Contributor Author

@robodoo r+ fw=no

(18.0+ there: #202894)

@robodoo
Copy link
Contributor

robodoo commented Mar 21, 2025

Disabled forward-porting.

@C3POdoo C3POdoo requested review from a team March 21, 2025 13:23
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 21, 2025
@robodoo
Copy link
Contributor

robodoo commented Mar 21, 2025

@alexkuhn 'ci/runbot' failed on this reviewed PR.

The composer should not send the current input on Enter key when being
on a mobile device, since it is impossible for them to create a new line
with either ctrl-Enter or alt-enter.

[FIX] mail: Discuss on Mobile - Enter key behavior

The composer should not send the current input on Enter key when being
on a mobile device, since it is impossible for them to create a new line
with either ctrl-Enter or alt-enter.

The style of send button in mobile was too subtle between active and
inactive. Since this button becomes the only way to send message in mobile,
its visual as been adapted to make it more obvious.

Task-4209142
@alexkuhn alexkuhn force-pushed the saas-17.4-discuss-fix-new-line-aku branch from 37412ad to 7b13068 Compare March 21, 2025 17:16
@alexkuhn
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 24, 2025
The composer should not send the current input on Enter key when being
on a mobile device, since it is impossible for them to create a new line
with either ctrl-Enter or alt-enter.

[FIX] mail: Discuss on Mobile - Enter key behavior

The composer should not send the current input on Enter key when being
on a mobile device, since it is impossible for them to create a new line
with either ctrl-Enter or alt-enter.

The style of send button in mobile was too subtle between active and
inactive. Since this button becomes the only way to send message in mobile,
its visual as been adapted to make it more obvious.

Task-4209142

closes #202917

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
@robodoo robodoo closed this Mar 24, 2025
@alexkuhn alexkuhn deleted the saas-17.4-discuss-fix-new-line-aku branch March 24, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants