[FW][IMP] account: validate mandatory analytic plans when batch posting #203153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mairasalazar @lordkrandel cherrypicking of pull request #201560 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
mairasalazar
force-pushed
the
saas-17.4-18.0-fix-mandatory-analytic-plans-srma-424841-fw
branch
from
4a9b272 to
515ea81
Compare
To replicate: 1. [Activate](https://www.odoo.com/documentation/18.0/applications/finance/accounting/reporting/analytic_accounting.html) Analytic Accounting: a. Install `accountant` b. In Settings, activate Analytic Accounting c. Create an Analytic plan (with an Analytic account associated) 2. Set the plan's default applicability to mandatory 3. Create two invoices, remove the analytic distribution from one of the lines in one invoice. 4. In the invoices list view, select both newly created invoices, click on Actions > Confirm Entries 5. Click Confirm 6. The invoices were posted, even though they have no analytic distributions. When we have an Analytic Plan being Mandatory, confirming an invoice from the form view, if it has a line without an Analytic distribution, correctly raises a ValidationError. Confirming invoices from the list view does not raise the same error, yet it should. This commit ensures the validation check for the mandatory analytic plans when mass posting entries, and adds a RedirectWarning to show a list view of the entries that should be reviewed. opw-4603919 X-original-commit: 9487a6b
mairasalazar
force-pushed
the
saas-17.4-18.0-fix-mandatory-analytic-plans-srma-424841-fw
branch
from
515ea81 to
8e4fb93
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 24, 2025
To replicate: 1. [Activate](https://www.odoo.com/documentation/18.0/applications/finance/accounting/reporting/analytic_accounting.html) Analytic Accounting: a. Install `accountant` b. In Settings, activate Analytic Accounting c. Create an Analytic plan (with an Analytic account associated) 2. Set the plan's default applicability to mandatory 3. Create two invoices, remove the analytic distribution from one of the lines in one invoice. 4. In the invoices list view, select both newly created invoices, click on Actions > Confirm Entries 5. Click Confirm 6. The invoices were posted, even though they have no analytic distributions. When we have an Analytic Plan being Mandatory, confirming an invoice from the form view, if it has a line without an Analytic distribution, correctly raises a ValidationError. Confirming invoices from the list view does not raise the same error, yet it should. This commit ensures the validation check for the mandatory analytic plans when mass posting entries, and adds a RedirectWarning to show a list view of the entries that should be reviewed. opw-4603919 closes #203153 X-original-commit: 9487a6b Signed-off-by: Paolo Gatti (pgi) <pgi@odoo.com> Signed-off-by: Maira Salazar <srma@odoo.com>
fw-bot
deleted the
saas-17.4-18.0-fix-mandatory-analytic-plans-srma-424841-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have an Analytic Plan being Mandatory, confirming an invoice from the form view, if it has a line without an Analytic distribution, correctly raises a ValidationError.
Confirming invoices from the list view does not raise the same error, yet it should.
To replicate:
a. Install
accountantb. In Settings, activate Analytic Accounting
c. Create an Analytic plan (with an Analytic account associated)
Ticket link
opw-4603919
Forward-Port-Of: #203006
Forward-Port-Of: #201560