[FW][FIX] point_of_sale, pos_sale: remove the payment terms on invoices from POS #203485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
forwardport
|
|
|
@mathcoutant @adgu-odoo cherrypicking of pull request #199385 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
mathcoutant
force-pushed
the
saas-18.2-17.0-opw-4458036-POS_terms_invoice-mcou-425245-fw
branch
from
47cfaea to
920b0e5
Compare
C3POdoo
requested review from
a team and
vlst-odoo
and removed request for
a team
mathcoutant
force-pushed
the
saas-18.2-17.0-opw-4458036-POS_terms_invoice-mcou-425245-fw
branch
from
920b0e5 to
50faf2b
Compare
|
@robodoo r+ |
|
@mathcoutant @adgu-odoo unable to stage: merge conflict |
mathcoutant
force-pushed
the
saas-18.2-17.0-opw-4458036-POS_terms_invoice-mcou-425245-fw
branch
from
50faf2b to
8f5afa4
Compare
|
@robodoo r+ |
|
@mathcoutant @adgu-odoo unable to stage: merge conflict |
|
@robodoo retry |
|
@mathcoutant @adgu-odoo unable to stage: merge conflict |
|
@mathcoutant @adgu-odoo this forward port of #199385 is awaiting action (not merged or closed). |
mathcoutant
force-pushed
the
saas-18.2-17.0-opw-4458036-POS_terms_invoice-mcou-425245-fw
branch
2 times, most recently
from
8c6d9b6 to
92a87ac
Compare
…rom POS Steps to reproduce: - In Accounting create a new Payment Term with an early discount set on "Always(upon invoice)" - Create a new Contact and add the payment term to this contact - Open POS and create an order - Select the new contact as the customer - Go to payment, select the option to create an invoice and validate - The receipt and the generated invoice have different amounts: the payment terms were applied on the invoice but not on the receipt Cause: POS does not consider at any point the payment terms so the total to be paid does not include the payment terms. Payment terms were included in invoices from POS with this [commit](odoo/odoo@c1cd62f) Solution: Remove the payment terms on invoices from POS. opw-4458036 X-original-commit: e74b1e2
mathcoutant
force-pushed
the
saas-18.2-17.0-opw-4458036-POS_terms_invoice-mcou-425245-fw
branch
from
92a87ac to
5f597f9
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 4, 2025
…rom POS Steps to reproduce: - In Accounting create a new Payment Term with an early discount set on "Always(upon invoice)" - Create a new Contact and add the payment term to this contact - Open POS and create an order - Select the new contact as the customer - Go to payment, select the option to create an invoice and validate - The receipt and the generated invoice have different amounts: the payment terms were applied on the invoice but not on the receipt Cause: POS does not consider at any point the payment terms so the total to be paid does not include the payment terms. Payment terms were included in invoices from POS with this [commit](c1cd62f) Solution: Remove the payment terms on invoices from POS. opw-4458036 closes #203485 X-original-commit: e74b1e2 Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com> Signed-off-by: Mathieu Coutant (mcou) <mcou@odoo.com>
fw-bot
deleted the
saas-18.2-17.0-opw-4458036-POS_terms_invoice-mcou-425245-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Cause:
POS does not consider at any point the payment terms so the total to be paid does not include the payment terms. Payment terms were included in invoices from POS with this commit
Solution:
Remove the payment terms on invoices from POS.
opw-4458036
Forward-Port-Of: #203252
Forward-Port-Of: #199385