[FW][FIX] html_editor: fix cropper issue with large images #204075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem**:
Loading large images into the cropper takes time. Closing the
cropper early causes `this.imageRef.el` to be `null` or
`this.initialSrc` to be `undefined`, leading to a traceback.
**What happens**:
1. Add a large image.
2. Click "Crop".
- This triggers `show`.
- While `loadImage` is still unresolved due to image size.
3. Click "Discard" to close the cropper before image loads.
- **Issue**: `this.imageRef.el` is `null` and `this.initialSrc`
is `undefined` as the component is destroyed but
`loadImage` has not resolved yet, when it is resolved
a traceback will be appear.
**Solution**:
Add a lifecycle flag to track the state of the cropper as full
mounting (including image loading) might take time.
**Steps to Reproduce**:
1. Add a large image.
2. Open cropper.
3. Close cropper before image loads.
- **Issue**: Traceback.
opw-4607020
X-original-commit: b11f332
|
|
|
This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@walidsahli @dmo-odoo the next pull request (#204076) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 29, 2025
**Problem**:
Loading large images into the cropper takes time. Closing the
cropper early causes `this.imageRef.el` to be `null` or
`this.initialSrc` to be `undefined`, leading to a traceback.
**What happens**:
1. Add a large image.
2. Click "Crop".
- This triggers `show`.
- While `loadImage` is still unresolved due to image size.
3. Click "Discard" to close the cropper before image loads.
- **Issue**: `this.imageRef.el` is `null` and `this.initialSrc`
is `undefined` as the component is destroyed but
`loadImage` has not resolved yet, when it is resolved
a traceback will be appear.
**Solution**:
Add a lifecycle flag to track the state of the cropper as full
mounting (including image loading) might take time.
**Steps to Reproduce**:
1. Add a large image.
2. Open cropper.
3. Close cropper before image loads.
- **Issue**: Traceback.
opw-4607020
closes #204075
X-original-commit: b11f332
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Walid Sahli (wasa) <wasa@odoo.com>
fw-bot
deleted the
saas-18.2-18.0-opw-4607020-fix_opening_closing_cropper_while_loading_image-wasa-425003-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Loading large images into the cropper takes time. Closing the cropper early causes
this.imageRef.elto benullorthis.initialSrcto beundefined, leading to a traceback.What happens:
show.loadImageis still unresolved due to image size.this.imageRef.elisnullandthis.initialSrcisundefinedas the component is destroyed butloadImagehas not resolved yet, when it is resolved a traceback will be appear.Solution:
Add a lifecycle flag as full mounting of the cropper might take time.
Steps to Reproduce:
opw-4607020
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #203102
Forward-Port-Of: #200729