[FW][FIX] html_editor: fix cropper issue with large images #204075
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Loading large images into the cropper takes time. Closing the cropper early causes
this.imageRef.el
to benull
orthis.initialSrc
to beundefined
, leading to a traceback.What happens:
show
.loadImage
is still unresolved due to image size.this.imageRef.el
isnull
andthis.initialSrc
isundefined
as the component is destroyed butloadImage
has not resolved yet, when it is resolved a traceback will be appear.Solution:
Add a lifecycle flag as full mounting of the cropper might take time.
Steps to Reproduce:
opw-4607020
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #203102
Forward-Port-Of: #200729