[FIX] survey: provide translations to frontend #204077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
requested review from
a team and
Julien00859
and removed request for
a team
Julien00859
approved these changes
Mar 31, 2025
This commit addresses translations not being exposed to the frontend. For surveys, no translatable terms existing in JavaScript are being translated. This mainly concerns `survey_form.js`. Lack of translations there easily results in a mix of languages being shown to a user answering a survey. Steps to reproduce: Install survey with demo data. Open and edit the "form feedback" survey. Change the question "What is your birth date" question. In the "option" tab, check the inbox "validate input" and set a min and max date. Start a live session with 1 attendee that uses another language than english. On the presenter side skip the first few questions to go to the "what is your birth date" question. On the attendee side, write down a date outside of the allowed range (don't use the date picket!). A warning message appears, that warning is not translated.
Julien00859
force-pushed
the
16.0-provide-survey-frontend-translations
branch
from
a58a5c3 to
ae68fb4
Compare
Julien00859
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
But wait... I'm part of the survey team too!
I reproduced the problem on my laptop and made sure your fix was correct. I took the liberty to change the commit message in order to include steps to reproduce the problem.
Thanks for the fix!
@flch-odoo mind to r+?
|
Oh well there was already another PR in our pipe with the exact same diff. Let's go. @robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2025
This commit addresses translations not being exposed to the frontend. For surveys, no translatable terms existing in JavaScript are being translated. This mainly concerns `survey_form.js`. Lack of translations there easily results in a mix of languages being shown to a user answering a survey. Steps to reproduce: Install survey with demo data. Open and edit the "form feedback" survey. Change the question "What is your birth date" question. In the "option" tab, check the inbox "validate input" and set a min and max date. Start a live session with 1 attendee that uses another language than english. On the presenter side skip the first few questions to go to the "what is your birth date" question. On the attendee side, write down a date outside of the allowed range (don't use the date picket!). A warning message appears, that warning is not translated. closes #204077 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
This commit addresses translations not being exposed to the frontend for the survey module.
Current behavior before PR:
For surveys, no translatable terms existing in JavaScript are being translated. This mainly concerns
survey_form.js.Lack of translations there easily results in a mix of languages being shown to a user answering a survey.
Desired behavior after PR is merged:
Translatable terms defined in JavaScript are translated to the user's language.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr