[FW][FIX] loyalty: prevent archiving product used for specific discounts #204300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR targets saas-18.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@lvsz @Demesmaeker child PR #204327 was modified / updated and has become a normal PR. This PR (and any of its parents) will need to be merged independently as approvals won't cross. |
Versions -------- - 16.0+ Steps ----- 1. Create a promotion program; 2. add a reward that offers a discount on a specific product; 3. specify a specific product; 4. archive the specified specific product; 5. create a sales order with a random product; 6. apply applicable rewards. Issue ----- The reward's specific discount has become applicable to all products. Cause ----- After archiving a product, the reward's `discount_product_ids` becomes empty unless `active_test=False` is added to the context. With this field empty, and no otherwise specified product domain, the discount can be applied to any product. Solution -------- Prevent archiving products that have an active program applying a specific discount to them. opw-4246768 X-original-commit: c6a5f01
lvsz
force-pushed
the
saas-18.1-16.0-opw-4246768-prevent_archiving_products_used_for_discount-sile-426897-fw
branch
from
df040a2 to
10af1d0
Compare
|
robodoo r+ |
|
@lvsz @Demesmaeker this PR was modified / updated and has become a normal PR. It must be merged directly. |
robodoo
pushed a commit
that referenced
this pull request
Apr 1, 2025
Versions -------- - 16.0+ Steps ----- 1. Create a promotion program; 2. add a reward that offers a discount on a specific product; 3. specify a specific product; 4. archive the specified specific product; 5. create a sales order with a random product; 6. apply applicable rewards. Issue ----- The reward's specific discount has become applicable to all products. Cause ----- After archiving a product, the reward's `discount_product_ids` becomes empty unless `active_test=False` is added to the context. With this field empty, and no otherwise specified product domain, the discount can be applied to any product. Solution -------- Prevent archiving products that have an active program applying a specific discount to them. opw-4246768 closes #204300 X-original-commit: c6a5f01 Signed-off-by: Morgane Demesmaeker <edm@odoo.com> Signed-off-by: Levi Siuzdak <sile@odoo.com>
fw-bot
deleted the
saas-18.1-16.0-opw-4246768-prevent_archiving_products_used_for_discount-sile-426897-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
Steps
Issue
The reward's specific discount has become applicable to all products.
Cause
After archiving a product, the reward's
discount_product_idsbecomes empty unlessactive_test=Falseis added to the context.With this field empty, and no otherwise specified product domain, the discount can be applied to any product.
Solution
Prevent archiving products that have an active program applying a specific discount to them.
opw-4246768
Forward-Port-Of: #204175
Forward-Port-Of: #203241