Skip to content

Conversation

@ksar-odoo
Copy link

@ksar-odoo ksar-odoo commented Apr 1, 2025

Root cause:

PR (#200327) did not add country code for CH_UNPAID

Fix:

Added country_id for work entry CH_UNPAID as it belongs to Switzerland

task-4687446


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Apr 1, 2025

Pull request status dashboard

@ksar-odoo ksar-odoo force-pushed the master-hr_work_entry-country-code-for-work-entry-ksar branch 3 times, most recently from 9ca8b09 to 9f82111 Compare April 1, 2025 12:32
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 1, 2025
@ksar-odoo ksar-odoo force-pushed the master-hr_work_entry-country-code-for-work-entry-ksar branch 2 times, most recently from 25f6cc3 to bdabc56 Compare April 10, 2025 06:08
Copy link
Contributor

@mepe-odoo mepe-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…H only

Root cause:
pr: odoo#200327 no country code added for CH_UNPAID

Fix:
Added country_id for work entry CH_UNPAID as it belongs to Switzerland

task-4687446
@tivisse tivisse force-pushed the master-hr_work_entry-country-code-for-work-entry-ksar branch from bdabc56 to 30ef604 Compare April 22, 2025 09:02
@tivisse
Copy link
Contributor

tivisse commented Apr 22, 2025

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Apr 22, 2025

@tivisse draft PRs can not be approved.

@tivisse tivisse marked this pull request as ready for review April 22, 2025 09:03
@tivisse
Copy link
Contributor

tivisse commented Apr 22, 2025

@robodoo r+

@C3POdoo C3POdoo requested a review from a team April 22, 2025 09:13
robodoo pushed a commit that referenced this pull request Apr 22, 2025
…H only

Root cause:
pr: #200327 no country code added for CH_UNPAID

Fix:
Added country_id for work entry CH_UNPAID as it belongs to Switzerland

task-4687446

closes #204310

Related: odoo/upgrade#7521
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
@robodoo robodoo added the 18.3 label Apr 23, 2025
@robodoo robodoo closed this Apr 23, 2025
@tivisse tivisse deleted the master-hr_work_entry-country-code-for-work-entry-ksar branch April 23, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

18.3 RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants