-
Notifications
You must be signed in to change notification settings - Fork 30.1k
[IMP] mail : Press 'End' or 'Alt+ArrowDown' to mark as read & jump to latest #204484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[IMP] mail : Press 'End' or 'Alt+ArrowDown' to mark as read & jump to latest #204484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: remove unnecessary elements from the PR description. Avoid overly technical language in the commit message and PR description. Keep it simple, yet ensure it's easy to understand what has been done in the commit/PR.
620bb61 to
b975893
Compare
a6ddf52 to
d71cba2
Compare
d71cba2 to
ef33cd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add a test coverage for this new feature. Thanks :)
ef33cd2 to
c474877
Compare
1fed04d to
c1e26c1
Compare
|
I pushed a version of ideal code that should be effectively used. Problem right now is chat window is stop propagating every keydown to not steal it's Ctrl+C from home menu. There's a problem for a long time that this stop propagation in chat window makes it not cooperate with hotkey service, and I think we should try to do solve the problem in another way than |
c1e26c1 to
b748e5e
Compare
Hello @alexkuhn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On macOS this is Ctrl rather than Alt.
Also make sure to apply our linter, see @web/tooling/enable.sh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @alexkuhn
I have updated the code to ensure that hotkeys work on both Windows and macOS.
Please review and let me know if any further changes are required.
…p to latest Improved user experience in Thread. Before this commit: - There was no way to jump to the last message in thread using the keyboard. - Users had to manually scroll to view the latest messages. After this commit: - Users can now use the 'Up Arrow' or 'Down Arrow' keyboard shortcut to directly jump to the most recent message in any Thread, improving accessibility and navigation efficiency. This enhances the user experience by providing quick keyboard-based navigation and better message handling. task-4686576
b748e5e to
f47d542
Compare

[IMP] mail : Press 'End' or 'Alt + Down Arrow' to mark as read & jump to latest
Improved user experience in Discuss app.
Before this commit:
keyboard.
After this commit:
directly jump to the most recent message in Discuss, improving accessibility
and navigation efficiency.
This enhances the user experience by providing quick keyboard-based navigation
and better message handling.
task-4686576