Skip to content

Conversation

@soza-odoo
Copy link
Contributor

@soza-odoo soza-odoo commented Apr 2, 2025

[IMP] mail : Press 'End' or 'Alt + Down Arrow' to mark as read & jump to latest

Improved user experience in Discuss app.

Before this commit:

  • There was no way to scroll down to the last message in Discuss using the
    keyboard.
  • Users had to manually scroll to view the latest messages.

After this commit:

  • Users can now use the 'End' key or 'Alt + Down Arrow' keyboard shortcut to
    directly jump to the most recent message in Discuss, improving accessibility
    and navigation efficiency.

This enhances the user experience by providing quick keyboard-based navigation
and better message handling.

task-4686576

@robodoo
Copy link
Contributor

robodoo commented Apr 2, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team April 2, 2025 12:10
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 2, 2025
@bhra-odoo bhra-odoo marked this pull request as draft April 4, 2025 06:23
Copy link
Contributor

@bhra-odoo bhra-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: remove unnecessary elements from the PR description. Avoid overly technical language in the commit message and PR description. Keep it simple, yet ensure it's easy to understand what has been done in the commit/PR.

@soza-odoo soza-odoo force-pushed the master-mail-imp-esc-btn-to-jump-latest-msg-soza branch 5 times, most recently from 620bb61 to b975893 Compare April 8, 2025 05:05
@soza-odoo soza-odoo force-pushed the master-mail-imp-esc-btn-to-jump-latest-msg-soza branch 3 times, most recently from a6ddf52 to d71cba2 Compare May 6, 2025 09:05
@alexkuhn alexkuhn changed the title [IMP] mail : Press Escape to mark message as read and jump to latest [IMP] mail : Press 'End' or 'Alt + Down Arrow' to mark as read & jump to latest May 6, 2025
@soza-odoo soza-odoo force-pushed the master-mail-imp-esc-btn-to-jump-latest-msg-soza branch from d71cba2 to ef33cd2 Compare May 6, 2025 11:56
Copy link
Contributor

@alexkuhn alexkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a test coverage for this new feature. Thanks :)

@soza-odoo soza-odoo force-pushed the master-mail-imp-esc-btn-to-jump-latest-msg-soza branch from ef33cd2 to c474877 Compare May 13, 2025 12:56
@alexkuhn alexkuhn changed the title [IMP] mail : Press 'End' or 'Alt + Down Arrow' to mark as read & jump to latest [IMP] mail : Press 'End' or 'Alt+ArrowDown' to mark as read & jump to latest May 13, 2025
@alexkuhn alexkuhn force-pushed the master-mail-imp-esc-btn-to-jump-latest-msg-soza branch 3 times, most recently from 1fed04d to c1e26c1 Compare September 5, 2025 19:49
@alexkuhn
Copy link
Contributor

alexkuhn commented Sep 5, 2025

I pushed a version of ideal code that should be effectively used.
Maybe ArrowUp/ArrowDown could be more appropriate than Home/End, we should not forget the hotkey have implicitly Alt (or Ctrl on MacOS) modifiers!

Problem right now is chat window is stop propagating every keydown to not steal it's Ctrl+C from home menu. There's a problem for a long time that this stop propagation in chat window makes it not cooperate with hotkey service, and I think we should try to do solve the problem in another way than stopPropagation() that results in isolating chat window from using hotkeys.

@soza-odoo soza-odoo force-pushed the master-mail-imp-esc-btn-to-jump-latest-msg-soza branch from c1e26c1 to b748e5e Compare September 11, 2025 09:12
@soza-odoo
Copy link
Contributor Author

soza-odoo commented Sep 11, 2025

I pushed a version of ideal code that should be effectively used. Maybe ArrowUp/ArrowDown could be more appropriate than Home/End, we should not forget the hotkey have implicitly Alt (or Ctrl on MacOS) modifiers!

Problem right now is chat window is stop propagating every keydown to not steal it's Ctrl+C from home menu. There's a problem for a long time that this stop propagation in chat window makes it not cooperate with hotkey service, and I think we should try to do solve the problem in another way than stopPropagation() that results in isolating chat window from using hotkeys.

Hello @alexkuhn
I just updated the chat window component so that we can use hotkeys and allow propagation for hotkeys in the chat window.
Will you please check if it will work, or if we have to handle it in another way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On macOS this is Ctrl rather than Alt.

Also make sure to apply our linter, see @web/tooling/enable.sh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @alexkuhn
I have updated the code to ensure that hotkeys work on both Windows and macOS.
Please review and let me know if any further changes are required.

…p to latest

Improved user experience in Thread.

Before this commit:
- There was no way to jump to the last message in thread using the
  keyboard.
- Users had to manually scroll to view the latest messages.

After this commit:
- Users can now use the 'Up Arrow' or 'Down Arrow' keyboard shortcut to
  directly jump to the most recent message in any Thread, improving accessibility
  and navigation efficiency.

This enhances the user experience by providing quick keyboard-based navigation
and better message handling.

task-4686576
@soza-odoo soza-odoo force-pushed the master-mail-imp-esc-btn-to-jump-latest-msg-soza branch from b748e5e to f47d542 Compare September 11, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants