-
Notifications
You must be signed in to change notification settings - Fork 30.1k
[FW][FIX] bus, hr_holidays, mail: inconsistent homeworking im status #204485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fw-bot
wants to merge
1
commit into
odoo:saas-18.2
from
odoo-dev:saas-18.2-17.0-homeworking-status-gito-426946-fw
Closed
[FW][FIX] bus, hr_holidays, mail: inconsistent homeworking im status #204485
fw-bot
wants to merge
1
commit into
odoo:saas-18.2
from
odoo-dev:saas-18.2-17.0-homeworking-status-gito-426946-fw
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Atovange cherrypicking of pull request #199936 failed. stdout:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Before this commit, the IM status icon shown when the user is homeworking won't always be precise. This happens because of the IM status refactoring (odoo#174814). Steps to reproduce: 1. Setup user Marc Demo as homeworking in the current day 2. As Marc Demo open Discuss 3. As Mitchell Admin open the conversation with Marc Demo -> the correct home online icon is shown 4. As Marc Demo close all Odoo tabs -> user goes offline and Mitchell Admin sees the correct offline icon 5. As Marc Demo reopen Discuss -> Mitchell Admin sees the circle icon instead of the home icon This commit fixes the issue by sending the user im_status information directly from its indentity model (`res.partner` or `mail.guest`) in the `bus.bus/im_status_updated` notification payload. This ensures that any overrides on the `im_status` field will be taken into consideration without having to re-establish the override client side. `presence_status` now represents the status value of the presence model, while `im_status` represents the status value of the identity model. X-original-commit: c74ef6a
6fcfa4a
to
61216b3
Compare
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 8, 2025
Before this commit, the IM status icon shown when the user is homeworking won't always be precise. This happens because of the IM status refactoring (#174814). Steps to reproduce: 1. Setup user Marc Demo as homeworking in the current day 2. As Marc Demo open Discuss 3. As Mitchell Admin open the conversation with Marc Demo -> the correct home online icon is shown 4. As Marc Demo close all Odoo tabs -> user goes offline and Mitchell Admin sees the correct offline icon 5. As Marc Demo reopen Discuss -> Mitchell Admin sees the circle icon instead of the home icon This commit fixes the issue by sending the user im_status information directly from its indentity model (`res.partner` or `mail.guest`) in the `bus.bus/im_status_updated` notification payload. This ensures that any overrides on the `im_status` field will be taken into consideration without having to re-establish the override client side. `presence_status` now represents the status value of the presence model, while `im_status` represents the status value of the identity model. closes #204485 X-original-commit: c74ef6a Signed-off-by: Giorgio Tocco (gito) <gito@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
RD
research & development, internal work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the IM status icon shown when the user is homeworking won't always be precise. This happens because of the IM status refactoring (#174814).
Steps to reproduce:
This commit fixes the issue by sending the user im_status information directly from its indentity model (
res.partner
ormail.guest
) in thebus.bus/im_status_updated
notification payload. This ensures that any overrides on theim_status
field will be taken into consideration without having to re-establish the override client side.presence_status
now represents the status value of the presence model, whileim_status
represents the status value of the identity model.Forward-Port-Of: #204307
Forward-Port-Of: #199936