[FW][FIX] survey: prevent division by zero crash on leaderboard #204913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce: 1. Make a scored live session survey 2. Add a single choice question with a <0.5 point answer (or < 1 with speed reward) 3. Create a live session 4. Join with one participant 5. Play the survey, have the participant answer correctly (after half the time for speed reward if that case is tested) 6. Proceed to leaderboard and expect a crash. This happens because when `max_score` or `max_score_question` are <= 0.5, divisions by round(<=.5) are divisions by 0. Using 3 digits for rounding has two advantages: * It is very unlikely that an answer will have a value below 0.0006 (not 0 - that case is supported- but rounds to 0). * It makes the template resilient to differences in precisions used for the various numbers (relevant in 17.4 where `answer_score` and `scoring_total` can be different by <0.01). Note that we stick to the minimal diff and do not change the values shown to not introduce decimal points showing up if they weren't shown before. Task-4655784 X-original-commit: f538369
|
|
|
This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Apr 5, 2025
Reproduce: 1. Make a scored live session survey 2. Add a single choice question with a <0.5 point answer (or < 1 with speed reward) 3. Create a live session 4. Join with one participant 5. Play the survey, have the participant answer correctly (after half the time for speed reward if that case is tested) 6. Proceed to leaderboard and expect a crash. This happens because when `max_score` or `max_score_question` are <= 0.5, divisions by round(<=.5) are divisions by 0. Using 3 digits for rounding has two advantages: * It is very unlikely that an answer will have a value below 0.0006 (not 0 - that case is supported- but rounds to 0). * It makes the template resilient to differences in precisions used for the various numbers (relevant in 17.4 where `answer_score` and `scoring_total` can be different by <0.01). Note that we stick to the minimal diff and do not change the values shown to not introduce decimal points showing up if they weren't shown before. Task-4655784 closes #204913 X-original-commit: f538369 Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com> Signed-off-by: Florian Charlier (flch) <flch@odoo.com>
fw-bot
deleted the
saas-18.2-16.0-survey-fix-leaderboard-division-by-zero-flch-427856-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce:
This happens because when
max_scoreormax_score_questionare <= 0.5, divisions by round(<=.5) are divisions by 0.Using 3 digits for rounding has two advantages:
answer_scoreandscoring_totalcan be different by <0.01).Task-4655784
Forward-Port-Of: #204907
Forward-Port-Of: #203988