[FW][FIX] l10n_*: remove countries from the manifest #205145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After odoo#144586, the modules other than base localization module should not have the `countries` key defined in their manifest. The issue happens because `countries` key works similar to auto-install and it can lead to unwanted installation of the module. As there was no check implemented, for some modules this key was used accidentally and caused issues with auto-install. This commit removes this field from the manifest of the modules that could have this problem to avoid the issue. Also in odoo#201526 a linting test is proposed to avoid having the same issue in the future. X-original-commit: 625529d
|
|
|
This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Apr 10, 2025
After #144586, the modules other than base localization module should not have the `countries` key defined in their manifest. The issue happens because `countries` key works similar to auto-install and it can lead to unwanted installation of the module. As there was no check implemented, for some modules this key was used accidentally and caused issues with auto-install. This commit removes this field from the manifest of the modules that could have this problem to avoid the issue. Also in #201526 a linting test is proposed to avoid having the same issue in the future. closes #205145 X-original-commit: 625529d Related: odoo/enterprise#83031 Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com> Signed-off-by: Ahmad Khanalizadeh (khah) <khah@odoo.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Apr 26, 2025
After odoo/odoo#144586, the modules other than base localization module should not have the `countries` key defined in their manifest. The issue happens because `countries` key works similar to auto-install and it can lead to unwanted installation of the module. As there was no check implemented, for some modules this key was used accidentally and caused issues with auto-install. This commit removes this field from the manifest of the modules that could have this problem to avoid the issue. Also in odoo/odoo#201526 a linting test is proposed to avoid having the same issue in the future. closes odoo/odoo#205145 X-original-commit: 625529dff7c833886af99f37f9a05122ad006764 Related: odoo/enterprise#83031 Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com> Signed-off-by: Ahmad Khanalizadeh (khah) <khah@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #144586, the modules other than base localization module should not have the
countrieskey defined in their manifest.The issue happens because
countrieskey works similar to auto-install and it can lead to unwanted installation of the module.As there was no check implemented, for some modules this key was used accidentally and caused issues with auto-install.
This commit removes this field from the manifest of the modules that could have this problem to avoid the issue.
Also in #201526 a linting test is proposed to avoid having the same issue in the future.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #201610