[FW][FIX] l10n_ch: prevent stopping pdf generation if in draft #206935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@yosa-odoo @rugo-odoo ci/runbot failed on this forward-port PR |
yosa-odoo
force-pushed
the
saas-18.2-17.0-opw-4585574-swiss_qr_draft_invoice-yosa-430989-fw
branch
from
96c2dbf to
1c8fb27
Compare
|
@yosa-odoo @rugo-odoo this PR was modified / updated and has become a normal PR. It must be merged directly. |
Steps to reproduce: - enable qr code - create an invoice with a swiss client - try to print it Issue: An error is raised Cause: There is no reference for a Swiss invoice in draft. If there is no reference, it is not possible to print the qr code in Switzerland. Solution: We prevent QR code generation whenever the invoice is in draft. By setting display_qr_code to False we by passe the qr code generation https://github.com/odoo/odoo/blob/d7770b7027b3668f906b8998d9d63df84ec1a7b3/addons/account/models/account_move.py#L4592-L4593 Note: Two tests have been modified to take into account that a move should be qr_valid https://github.com/odoo/odoo/blob/9e7ae71933e691205e21567d1b71c384fece7d3f/addons/l10n_ch/models/account_invoice.py#L44 Which is possible only if not in draft opw-4585574 ______ correction from odoo#205879 Through the many iteration, one of the condition was removed: odoo#198498 and `move.display_qr_code` is not enough to translate the apparently necessary condition `move.company_id.account_fiscal_country_id.code == 'CH'` odoo@84152f2 Testing the flow is quite complex without tour hence the the `assert` X-original-commit: be08386
yosa-odoo
force-pushed
the
saas-18.2-17.0-opw-4585574-swiss_qr_draft_invoice-yosa-430989-fw
branch
from
1c8fb27 to
4955c91
Compare
fw-bot
deleted the
saas-18.2-17.0-opw-4585574-swiss_qr_draft_invoice-yosa-430989-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
An error is raised
Cause:
There is no reference for a Swiss invoice in draft. If there is no reference, it is not possible to print the qr code in Switzerland.
Solution:
We prevent QR code generation whenever the invoice is in draft.
opw-4585574
Forward-Port-Of: #204661
Forward-Port-Of: #198498