[FW][FIX] sale_timesheet : Prevent linking not-invoiced timesheet to invoice

[fw-bot]

Steps to reproduce:

- Create a recurring service (product) with invoicing policy set as 'Based on Timesheets'
- Create a subscription using the created product
- Create a task and link it to this subscription order
- Timesheet 3 line in the task one in the past one on the same date of creation and one in the future.
- Create an invoice for this order
- Notice the quantity has been invoiced is the present timesheet line only
- Notice that the 3 timesheet lines have all been validated

Cause:

This is happening because when trying to link the lines to the invoice we consider the timesheets within the date range that the user might have set in the create invoice wizard.

odoo/addons/sale_timesheet/wizard/sale_make_invoice_advance.py

Lines 33 to 51 in 9a4ec08

	def _create_invoices(self, sale_orders):
	""" Override method from sale/wizard/sale_make_invoice_advance.py
	When the user want to invoice the timesheets to the SO
	up to a specific period then we need to recompute the
	qty_to_invoice for each product_id in sale.order.line,
	before creating the invoice.
	"""
	if self.advance_payment_method == 'delivered' and self.invoicing_timesheet_enabled:
	if self.date_start_invoice_timesheet or self.date_end_invoice_timesheet:
	sale_orders.order_line._recompute_qty_to_invoice(
	self.date_start_invoice_timesheet, self.date_end_invoice_timesheet)
	return sale_orders.with_context(
	timesheet_start_date=self.date_start_invoice_timesheet,
	timesheet_end_date=self.date_end_invoice_timesheet
	)._create_invoices(final=self.deduct_down_payments, grouped=not self.consolidated_billing)
	return super()._create_invoices(sale_orders)

odoo/addons/sale_timesheet/models/sale_order.py

Line 153 in 9a4ec08

moves._link_timesheets_to_invoice(self.env.context.get("timesheet_start_date"), self.env.context.get("timesheet_end_date"))

Fix:

In subscription we can use the last and next invoice dates if the user hasn't set a period for the invoice.

opw-4523727

Forward-Port-Of: #205782
Forward-Port-Of: #205029

[robodoo]

[fw-bot]

This PR targets saas-18.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port