Skip to content

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Aug 30, 2025

We provide a SMS service for our clients through an IAP service. It has almost no annoying configuration, the Odoo database sends stuff to an IAP proxy, that sends the SMS to our providers for them. Cool, easy, it's used quite a bit.

BUT for this to work, Odoo "registers" itself to our providers in the name of our clients. The problem is that the situation with Mobile operators in many countries is rapidly evolving, and more and more countries now require the clients themselves to submit an authorization request to be able to send SMS on their network. As such, Odoo is not supposed to register itself in place of its client. In some countries (and big ones, like USA, Australia, UK and soon France), this service is not working well, or at all, anymore.

The registration process is fastidious, and on top of them it changes from country to country. We do not want to start implementing registration processes by countries just for SMS sending.

For that reason, we will start to provide a new module where we remove the IAP part and connect directly to a new provider: Twilio. Clients will do all the registration themselves directly with the provider, and setup their account in Odoo to send those SMS. Twilio is a well known provider with extensive coverage, ideal for a global solution like Odoo.

task-4658352

Forward-Port-Of: #206818

@robodoo
Copy link
Contributor

robodoo commented Aug 30, 2025

Pull request status dashboard

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Aug 30, 2025
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 30, 2025

cherrypicking of pull request #206818 failed.

stdout:

Auto-merging .tx/config
CONFLICT (content): Merge conflict in .tx/config
Auto-merging addons/mass_mailing_sms/tests/common.py
CONFLICT (content): Merge conflict in addons/mass_mailing_sms/tests/common.py
Auto-merging addons/mass_mailing_sms/wizard/mailing_sms_test.py
CONFLICT (content): Merge conflict in addons/mass_mailing_sms/wizard/mailing_sms_test.py
Auto-merging addons/phone_validation/tools/phone_validation.py
CONFLICT (content): Merge conflict in addons/phone_validation/tools/phone_validation.py
Auto-merging addons/sms/models/__init__.py
Auto-merging addons/sms/models/sms_sms.py
Auto-merging addons/sms/tests/common.py
CONFLICT (content): Merge conflict in addons/sms/tests/common.py
Auto-merging addons/sms/tools/sms_api.py
CONFLICT (content): Merge conflict in addons/sms/tools/sms_api.py
Auto-merging addons/sms/wizard/sms_composer.py
Auto-merging addons/test_mail_sms/tests/test_sms_performance.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 30, 2025

WARNING: the latest change (8c36dc9699ce8064b6c44ea9343cbb09aad972c9) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 30, 2025

WARNING: the latest change (8c36dc9699ce8064b6c44ea9343cbb09aad972c9) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@tde-banana-odoo tde-banana-odoo force-pushed the 18.0-17.0-sms-twilio-rigr-430781-fw branch from 8c36dc9 to 3e014d8 Compare August 30, 2025 14:11
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 30, 2025

WARNING: the latest change (3e014d8fa5efb0ad62ffe5db546be6ecdec12e04) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@tde-banana-odoo tde-banana-odoo force-pushed the 18.0-17.0-sms-twilio-rigr-430781-fw branch from 3e014d8 to a68552a Compare August 30, 2025 14:17
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 30, 2025

WARNING: the latest change (a68552a9037d9b244a55a743ab9b22a068330e20) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@tde-banana-odoo tde-banana-odoo force-pushed the 18.0-17.0-sms-twilio-rigr-430781-fw branch from a68552a to a006cdd Compare August 30, 2025 18:07
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 30, 2025

WARNING: the latest change (a006cddf5849b6dcec5f7d72f314235b2f85f206) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@C3POdoo C3POdoo requested review from a team August 30, 2025 18:10
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 30, 2025

WARNING: the latest change (ea0f4a8760b883cea48bc3e11f8d78ea73f48879) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@tde-banana-odoo tde-banana-odoo force-pushed the 18.0-17.0-sms-twilio-rigr-430781-fw branch from ea0f4a8 to 6567bbc Compare August 31, 2025 08:31
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 31, 2025

WARNING: the latest change (6567bbc24705c9a3f1c4f6f8b559909b8a1fdf12) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

1 similar comment
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 31, 2025

WARNING: the latest change (6567bbc24705c9a3f1c4f6f8b559909b8a1fdf12) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@tde-banana-odoo tde-banana-odoo force-pushed the 18.0-17.0-sms-twilio-rigr-430781-fw branch from 6567bbc to 4c41bf6 Compare August 31, 2025 09:20
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 31, 2025

WARNING: the latest change (4c41bf66b56887de2d639ed74f1d10bb6071d8c5) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

RicGR98 and others added 4 commits August 31, 2025 11:57
Current situation

We provide a SMS service for our clients through an IAP service. I
has almost no annoying configuration, the Odoo database sends data
to an IAP proxy, that sends the SMS to our providers for them. It
is easy to use and user friendly.

Issue

For this to work, Odoo "registers" itself to our providers in behalf
of our clients. The problem with Mobile operators in many countries
it is often asked for the clients to register themselves and submit
an authorization request to be able to send SMS on their network.

As such, Odoo is not supposed to register itself in place of their
customers. In some countries like USA, Australia, UK and soon France
this service is not working well or even at all.

Solution

Registration process is fastidious, and on top of them it changes
from country to country. We do not want to start implementing
registration processes by countries just for SMS sending.

For that reason, we will start to provide a new module where we
remove the IAP part and connect directly to a new provider: Twilio.
Clients will do all the registration themselves directly with the
provider, and setup their account in Odoo to send those SMS.
Twilio is a well known provider with extensive coverage, ideal
for a global solution like Odoo.

Stable target

This module targets 17.0 which is going to be the oldest supported
version soonish. It is going to be forward ported until master. It
should be stable compliant and should not break any flow involving
IAP contact.

Bridge support for SMS marketing and therefore marketing automation
is provided.

Task-4658352

X-original-commit: aa04aeb
Co-authored-by: Thibault Delavallee <tde@odoo.com>
It should always belong to a company, hence making the field required
and made deletion cascading.

Task-5053537
Purpose is to test support and propagation of various errors in tests.

Task-5053537
'success' or 'sent' can be received when succeeding, leading to
a more correct notification message.

Task-5053537
@tde-banana-odoo tde-banana-odoo force-pushed the 18.0-17.0-sms-twilio-rigr-430781-fw branch from 4c41bf6 to b41b829 Compare August 31, 2025 09:57
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 31, 2025

WARNING: the latest change (b41b829) triggered a conflict when updating the next forward-port (#224899), and has been ignored.

You will need to update this pull request differently, or fix the issue by hand on #224899.

@tde-banana-odoo
Copy link
Contributor

@robodoo override=ci/security

See #206818 (review)

@tde-banana-odoo
Copy link
Contributor

@robodoo r+ rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Aug 31, 2025

Merge method set to rebase and fast-forward.

@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 31, 2025

child PR #224899 has become a normal PR because head updated from 85af790d1ad0656a76c353f9e7bf0bb54336f9f7 to 30a13abdf27d0f1886ae23ce1f7c182749e0f80d. This PR (and any of its parents) will need to be merged independently as approvals won't cross.

robodoo pushed a commit that referenced this pull request Aug 31, 2025
Current situation

We provide a SMS service for our clients through an IAP service. I
has almost no annoying configuration, the Odoo database sends data
to an IAP proxy, that sends the SMS to our providers for them. It
is easy to use and user friendly.

Issue

For this to work, Odoo "registers" itself to our providers in behalf
of our clients. The problem with Mobile operators in many countries
it is often asked for the clients to register themselves and submit
an authorization request to be able to send SMS on their network.

As such, Odoo is not supposed to register itself in place of their
customers. In some countries like USA, Australia, UK and soon France
this service is not working well or even at all.

Solution

Registration process is fastidious, and on top of them it changes
from country to country. We do not want to start implementing
registration processes by countries just for SMS sending.

For that reason, we will start to provide a new module where we
remove the IAP part and connect directly to a new provider: Twilio.
Clients will do all the registration themselves directly with the
provider, and setup their account in Odoo to send those SMS.
Twilio is a well known provider with extensive coverage, ideal
for a global solution like Odoo.

Stable target

This module targets 17.0 which is going to be the oldest supported
version soonish. It is going to be forward ported until master. It
should be stable compliant and should not break any flow involving
IAP contact.

Bridge support for SMS marketing and therefore marketing automation
is provided.

Task-4658352

X-original-commit: aa04aeb
Part-of: #224898
Related: odoo/enterprise#93569
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Thibault Delavallee <tde@odoo.com>
robodoo pushed a commit that referenced this pull request Aug 31, 2025
It should always belong to a company, hence making the field required
and made deletion cascading.

Task-5053537

Part-of: #224898
Related: odoo/enterprise#93569
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo pushed a commit that referenced this pull request Aug 31, 2025
Purpose is to test support and propagation of various errors in tests.

Task-5053537

Part-of: #224898
Related: odoo/enterprise#93569
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo robodoo closed this in 84e1638 Aug 31, 2025
@fw-bot fw-bot deleted the 18.0-17.0-sms-twilio-rigr-430781-fw branch September 7, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants