[FIX] html_editor: fix backward table selection in Firefox #227694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
sbbh-odoo
force-pushed
the
18.0-fix-table-selection-firefox-sbbh
branch
2 times, most recently
from
1b81980 to
4d5aaff
Compare
Steps to Reproduce: 1. Create a table in the editor (Firefox). 2. Select table cells backward (right → left or bottom → top). Before this commit: - The first selected cell does not remain selected in Firefox when extending the selection backward. After this commit: - Backward table cell selection works consistently in Firefox. task-5094832
sbbh-odoo
force-pushed
the
18.0-fix-table-selection-firefox-sbbh
branch
from
4d5aaff to
4e8b1c8
Compare
deso-odoo
reviewed
Oct 16, 2025
| selection.getRangeAt(selection.rangeCount - 1).startContainer, | ||
| selection.getRangeAt(selection.rangeCount - 1).startOffset | ||
| ); | ||
| if (this.selectionDirection === "backward") { |
Contributor
There was a problem hiding this comment.
Can we use getCursorDirection here?
Contributor
Author
There was a problem hiding this comment.
No, we can’t. When a selection contains multiple ranges, it includes the entire parent <tr>, so the direction is always 'forward'. That’s why we need to store the direction from the very first selection.
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 5, 2025
Steps to Reproduce: 1. Create a table in the editor (Firefox). 2. Select table cells backward (right → left or bottom → top). Before this commit: - The first selected cell does not remain selected in Firefox when extending the selection backward. After this commit: - Backward table cell selection works consistently in Firefox. task-5094832 closes #227694 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce:
Description of the issue this PR addresses:
task-5094832
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr