[FIX] web: Prevent focusCell() error on destroyed components #232156

fw-bot · 2025-10-17T15:47:43Z

Steps to Reproduce:

Open a Repair Order form view in Odoo 17 or 18.
Navigate to the Parts tab.
In the list view of parts, click the Smart Button on any part line.
A pop-up form view opens showing detailed operations.
Click the “Pick From” field value, but don't change its value.
Click the Save button in the pop-up.
Observe the browser console for the error: TypeError: Cannot read properties of null (reading 'querySelector') at ListRenderer.focusCell

Traceback:

TypeError: Cannot read properties of null (reading 'querySelector')
    at ListRenderer.focusCell (https://91307582-17-0-all.runbot219.odoo.com/web/assets/15b4f47/web.assets_web.min.js:9519:80)
    at ListRenderer.<anonymous> (https://91307582-17-0-all.runbot219.odoo.com/web/assets/15b4f47/web.assets_web.min.js:9477:272)

Root Cause:

Asynchronous patching in OWL (onPatched with await Promise.resolve()) continues execution after the next tick, even if the component is destroyed.
When the component is destroyed, OWL sets status(this) = 3 (DESTROYED).
focusCell() accesses DOM using querySelector, which fails if the component is destroyed.
The code did not check the component status before calling focusCell().

Fix:

Added if (status(this) === destroyed) return; to stop focusCell() execution on destroyed components.
Ensured async patching is handled safely with await Promise.resolve().
Added onWillDestroy to clean up dialog callbacks, preventing memory leaks.

OPW - 5154694
PAD
Localhost issue reproduction steps

17:

odoo/addons/web/static/src/views/list/list_renderer.js

Line 223 in f9726cf

onPatched(async () => {

18:

odoo/addons/web/static/src/views/list/list_renderer.js

Line 213 in 1cac54d

onPatched(async () => {

Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #232097

robodoo · 2025-10-17T15:47:44Z

fw-bot · 2025-10-17T15:47:45Z

@shku-odoo @aab-odoo cherrypicking of pull request #232097 failed.

stdout:

Auto-merging addons/web/static/src/views/list/list_renderer.js
CONFLICT (content): Merge conflict in addons/web/static/src/views/list/list_renderer.js

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot · 2025-10-25T02:01:06Z

@shku-odoo @aab-odoo this forward port of #232097 is awaiting action (not merged or closed).

aab-odoo · 2025-10-27T07:07:17Z

@shku-odoo don't forget this forwardport. There's a small conflict to resolve. Thanks

fw-bot · 2025-11-01T02:01:28Z

@shku-odoo @aab-odoo this forward port of #232097 is awaiting action (not merged or closed).

aab-odoo

robodoo r+

robodoo · 2025-11-03T07:40:39Z

@shku-odoo @aab-odoo 'ci/runbot' failed on this reviewed PR.

Steps to Reproduce: - Open a Repair Order form view in Odoo 17 or 18. - Navigate to the Parts tab. - In the list view of parts, click the Smart Button on any part line. - A pop-up form view opens showing detailed operations. - Click the “Pick From” field value, but don't change its value. - Click the Save button in the pop-up. - Observe the browser console for the error: TypeError: Cannot read properties of null (reading 'querySelector') at ListRenderer.focusCell Root Cause: - Asynchronous patching in OWL (onPatched with await Promise.resolve()) continues execution after the next tick, even if the component is destroyed. - When the component is destroyed, OWL sets status(this) = 3 (DESTROYED). - focusCell() accesses DOM using querySelector, which fails if the component is destroyed. - The code did not check the component status before calling focusCell(). Fix: - Added `if (status(this) === destroyed) return;` to stop focusCell() execution on destroyed components. - Ensured async patching is handled safely with await Promise.resolve(). 17: https://github.com/odoo/odoo/blob/f9726cfe93e8850a38d9de06acfa5d78473b50b0/addons/web/static/src/views/list/list_renderer.js#L223 18: https://github.com/odoo/odoo/blob/1cac54db8634267a780b4011291f1e8a80ac5f5b/addons/web/static/src/views/list/list_renderer.js#L213 X-original-commit: c4ec69a

aab-odoo

robodoo r+

Steps to Reproduce: - Open a Repair Order form view in Odoo 17 or 18. - Navigate to the Parts tab. - In the list view of parts, click the Smart Button on any part line. - A pop-up form view opens showing detailed operations. - Click the “Pick From” field value, but don't change its value. - Click the Save button in the pop-up. - Observe the browser console for the error: TypeError: Cannot read properties of null (reading 'querySelector') at ListRenderer.focusCell Root Cause: - Asynchronous patching in OWL (onPatched with await Promise.resolve()) continues execution after the next tick, even if the component is destroyed. - When the component is destroyed, OWL sets status(this) = 3 (DESTROYED). - focusCell() accesses DOM using querySelector, which fails if the component is destroyed. - The code did not check the component status before calling focusCell(). Fix: - Added `if (status(this) === destroyed) return;` to stop focusCell() execution on destroyed components. - Ensured async patching is handled safely with await Promise.resolve(). 17: https://github.com/odoo/odoo/blob/f9726cfe93e8850a38d9de06acfa5d78473b50b0/addons/web/static/src/views/list/list_renderer.js#L223 18: https://github.com/odoo/odoo/blob/1cac54db8634267a780b4011291f1e8a80ac5f5b/addons/web/static/src/views/list/list_renderer.js#L213 closes #232156 X-original-commit: c4ec69a Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Steps to Reproduce: - Open a Repair Order form view in Odoo 17 or 18. - Navigate to the Parts tab. - In the list view of parts, click the Smart Button on any part line. - A pop-up form view opens showing detailed operations. - Click the “Pick From” field value, but don't change its value. - Click the Save button in the pop-up. - Observe the browser console for the error: TypeError: Cannot read properties of null (reading 'querySelector') at ListRenderer.focusCell Root Cause: - Asynchronous patching in OWL (onPatched with await Promise.resolve()) continues execution after the next tick, even if the component is destroyed. - When the component is destroyed, OWL sets status(this) = 3 (DESTROYED). - focusCell() accesses DOM using querySelector, which fails if the component is destroyed. - The code did not check the component status before calling focusCell(). Fix: - Added `if (status(this) === destroyed) return;` to stop focusCell() execution on destroyed components. - Ensured async patching is handled safely with await Promise.resolve(). 17: https://github.com/odoo/odoo/blob/f9726cfe93e8850a38d9de06acfa5d78473b50b0/addons/web/static/src/views/list/list_renderer.js#L223 18: https://github.com/odoo/odoo/blob/1cac54db8634267a780b4011291f1e8a80ac5f5b/addons/web/static/src/views/list/list_renderer.js#L213 closes odoo#232156 X-original-commit: c4ec69a Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Oct 17, 2025

shku-odoo force-pushed the 18.0-17.0-fix-repair-order-focuscell-destroyed-471248-fw branch from cfffaf1 to ab0cfb1 Compare November 3, 2025 07:12

C3POdoo requested review from a team, BastienFafchamps and aab-odoo and removed request for a team November 3, 2025 07:14

aab-odoo approved these changes Nov 3, 2025

View reviewed changes

shku-odoo force-pushed the 18.0-17.0-fix-repair-order-focuscell-destroyed-471248-fw branch from ab0cfb1 to 0bc73ce Compare November 3, 2025 08:58

shku-odoo force-pushed the 18.0-17.0-fix-repair-order-focuscell-destroyed-471248-fw branch from 0bc73ce to a1d7cc1 Compare November 4, 2025 07:11

aab-odoo approved these changes Nov 4, 2025

View reviewed changes

robodoo temporarily deployed to merge November 4, 2025 10:53 Inactive

robodoo closed this Nov 4, 2025

fw-bot mentioned this pull request Nov 4, 2025

[FIX] web: Prevent focusCell() error on destroyed components #234317

Closed

fw-bot deleted the 18.0-17.0-fix-repair-order-focuscell-destroyed-471248-fw branch November 11, 2025 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FIX] web: Prevent focusCell() error on destroyed components #232156

[FIX] web: Prevent focusCell() error on destroyed components #232156

Uh oh!

fw-bot commented Oct 17, 2025

Uh oh!

robodoo commented Oct 17, 2025

Uh oh!

fw-bot commented Oct 17, 2025

Uh oh!

fw-bot commented Oct 25, 2025

Uh oh!

aab-odoo commented Oct 27, 2025

Uh oh!

fw-bot commented Nov 1, 2025

Uh oh!

aab-odoo left a comment

Uh oh!

robodoo commented Nov 3, 2025

Uh oh!

aab-odoo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[FIX] web: Prevent focusCell() error on destroyed components #232156

[FIX] web: Prevent focusCell() error on destroyed components #232156

Uh oh!

Conversation

fw-bot commented Oct 17, 2025

Uh oh!

robodoo commented Oct 17, 2025

Uh oh!

fw-bot commented Oct 17, 2025

Uh oh!

fw-bot commented Oct 25, 2025

Uh oh!

aab-odoo commented Oct 27, 2025

Uh oh!

fw-bot commented Nov 1, 2025

Uh oh!

aab-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

robodoo commented Nov 3, 2025

Uh oh!

aab-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants