[FIX] account: Ref rounding of tax_details for better handling of price-included #232207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, `_distribute_delta_amounts_smoothly` requires the factors to be pre-nomalized. However, normalizing the factors robustly requires more logic than just dividing by the sum of factors, especially if the factors have different signs. This commit moves the normalization into `_distribute_delta_amounts_smoothly` itself meaning the calling code doesn't need to take care of it anymore. task-none X-original-commit: 6c4133a
…ce-included == Fix bug price-included == Suppose a line of 24.99 with a 20% tax price-included. base: 24.99 / 1.2 = 20.825 tax: 20.825 * 0.2 = 4.165 If we round both, we get 20.83 + 4.17 = 25.0 != 24.99 == Split and simplify round_base_line_tax_details == Easier implementation of this method to be easier to understand and easier to be customized (see PT override). Also, we now use the aggregate methods to aggregate the amounts instead of doing that by hand. opw-4505888 X-original-commit: 5c19c3c
Contributor
|
|
Contributor
Author
|
@smetl @antoine162 this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
smetl
approved these changes
Oct 17, 2025
robodoo
pushed a commit
that referenced
this pull request
Oct 18, 2025
At the moment, `_distribute_delta_amounts_smoothly` requires the factors to be pre-nomalized. However, normalizing the factors robustly requires more logic than just dividing by the sum of factors, especially if the factors have different signs. This commit moves the normalization into `_distribute_delta_amounts_smoothly` itself meaning the calling code doesn't need to take care of it anymore. task-none X-original-commit: 6c4133a Part-of: #232207 Related: odoo/enterprise#97567 Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com> Signed-off-by: Laurent Smet (las) <las@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Oct 18, 2025
…ce-included == Fix bug price-included == Suppose a line of 24.99 with a 20% tax price-included. base: 24.99 / 1.2 = 20.825 tax: 20.825 * 0.2 = 4.165 If we round both, we get 20.83 + 4.17 = 25.0 != 24.99 == Split and simplify round_base_line_tax_details == Easier implementation of this method to be easier to understand and easier to be customized (see PT override). Also, we now use the aggregate methods to aggregate the amounts instead of doing that by hand. opw-4505888 closes #232207 X-original-commit: 5c19c3c Related: odoo/enterprise#97567 Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com> Signed-off-by: Laurent Smet (las) <las@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Fix bug price-included ==
Suppose a line of 24.99 with a 20% tax price-included.
base: 24.99 / 1.2 = 20.825
tax: 20.825 * 0.2 = 4.165
If we round both, we get 20.83 + 4.17 = 25.0 != 24.99
== Split and simplify round_base_line_tax_details ==
Easier implementation of this method to be easier to understand and
easier to be customized (see PT override). Also, we now use the
aggregate methods to aggregate the amounts instead of doing that by hand.
opw-4505888
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #232025
Forward-Port-Of: #228437