[FIX] l10n_tw_edi_ecpay: correct JSON data handling for downpayment invoices #233359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
hatr-odoo
requested review from
a team and
mairasalazar
and removed request for
a team
mairasalazar
requested changes
Nov 3, 2025
Contributor
mairasalazar
left a comment
mairasalazar
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a small comment :)
hatr-odoo
force-pushed
the
18.0-l10n_tw_edi_ecpay-fix-dp-invoice-json-hatr
branch
from
3b51aa2 to
81fcbba
Compare
mairasalazar
approved these changes
Nov 4, 2025
Contributor
mairasalazar
left a comment
mairasalazar
left a comment
There was a problem hiding this comment.
Thank you for the changes! I left some minor nitpicking comments, but non-blocking, so I'll send it to the final reviewer :)
hatr-odoo
force-pushed
the
18.0-l10n_tw_edi_ecpay-fix-dp-invoice-json-hatr
branch
from
81fcbba to
6b361dc
Compare
Contributor
Author
|
@mairasalazar thanks for the review. Could you plz request the final reviewer to this PR? |
|
@hatr-odoo |
epictete
reviewed
Nov 5, 2025
…nvoices When an invoice is created from a sale order with a downpayment, the invoice line for the downpayment typically has a negative quantity and a positive unit price. However, ECPay does not accept negative quantities, and this also leads to incorrect price values being sent in the JSON payload. To address this, when an invoice line has a negative quantity, it is inverted to ensure the data sent to ECPay is valid and consistent. task-5211264
hatr-odoo
force-pushed
the
18.0-l10n_tw_edi_ecpay-fix-dp-invoice-json-hatr
branch
from
6b361dc to
01ae114
Compare
william-andre
approved these changes
Nov 5, 2025
epictete
approved these changes
Nov 5, 2025
robodoo
pushed a commit
that referenced
this pull request
Nov 5, 2025
…nvoices When an invoice is created from a sale order with a downpayment, the invoice line for the downpayment typically has a negative quantity and a positive unit price. However, ECPay does not accept negative quantities, and this also leads to incorrect price values being sent in the JSON payload. To address this, when an invoice line has a negative quantity, it is inverted to ensure the data sent to ECPay is valid and consistent. task-5211264 closes #233359 Signed-off-by: John Laterre (jol) <jol@odoo.com>
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invoice is created from a sale order with a downpayment, the invoice line for the downpayment typically has a negative quantity and a positive unit price. However, ECPay does not accept negative quantities, and this also leads to incorrect price values being sent in the JSON payload.
To address this, when an invoice line has a negative quantity, it is inverted to ensure the data sent to ECPay is valid and consistent.
task-5211264