Fix proxy mode for werkzeug 0.15, 12.0 edition #37709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Werkzeug 0.15 modified ProxyFix such that by default it only forwards the REMOTE_ADDR when enabled, whereas before 0.15 it would also forward scheme and host. This breaks proxied odoo as the base url becomes incorrect (cf odoo#34412). Use properly configured ProxyFix when running with werkzeug 0.15, old configuration otherwise. Backport of 4057227 which was merged in master, because many people apparently run 0.15 now. Closes odoo#35085 closes odoo#36212
|
@fw-bot up to 12.4 |
|
There is no branch '12.4', it can't be used as a forward port target. |
|
@fw-bot up to saas-12.4 |
|
Forward-porting to 'saas-12.4'. |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 25, 2019
Werkzeug 0.15 modified ProxyFix such that by default it only forwards the REMOTE_ADDR when enabled, whereas before 0.15 it would also forward scheme and host. This breaks proxied odoo as the base url becomes incorrect (cf #34412). Use properly configured ProxyFix when running with werkzeug 0.15, old configuration otherwise. Backport of 4057227 which was merged in master, because many people apparently run 0.15 now. Closes #35085 closes #36212 closes #37709 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
|
Merged at e19d624, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36212 which was merged in master but we might as well merge it in 12 too per @odony's comment.
See also #37708