[IMP] compiler: improve expression parser scoping and template string handling#1883
Merged
ged-odoo merged 1 commit intoMay 12, 2026
Merged
Conversation
… handling The current expression parser uses a flat local variable tracking mechanism, which leads to incorrect behavior in nested arrow functions and template string interpolations. This commit introduces a scope stack to properly track variable scopes across nested expressions. It also propagates local variables into template string interpolations to ensure correct variable resolution. Key improvements: - Proper handling of nested arrow function scopes - Correct tracking of local variables using a scope stack - Support for seeded locals in template string expressions - Prevent incorrect context lookups inside template strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current expression parser uses a flat local variable tracking mechanism, which leads to incorrect behavior in nested arrow functions and template string interpolations.
This commit introduces a scope stack to properly track variable scopes across nested expressions. It also propagates local variables into template string interpolations to ensure correct variable resolution.
Key improvements: