[IMP] awesome_owl: added counter, card and todo_list components - MOALN #1018
Conversation
|
|
Mohamed-Khaled308
changed the title
There was a problem hiding this comment.
Hi @Mohamed-Khaled308 👋,
Here is a quick review of your PR. My comments are about details. For the git stuff we can check it together tomorrow.
The title of your PR is good, you should just remove your pentagram at the end of it.
Cheers!
| @@ -1,6 +0,0 @@ | |||
| <component name="InspectionProjectProfileManager"> | |||
There was a problem hiding this comment.
Can you squash the commit "[REM] tutorials: removed .idea files" inside the commit "[IMP] awesome_owl: added counter and todolist components" ? This will remove all .idea files from your commits, making your PR cleaner.
|
|
||
|
|
||
| export class Card extends Component { | ||
| static template = "awesome_owl.card"; |
There was a problem hiding this comment.
| static template = "awesome_owl.card"; | |
| static template = "awesome_owl.Card"; |
| import { Component, useState } from "@odoo/owl"; | ||
|
|
||
| export class Counter extends Component { | ||
| static template = "awesome_owl.counter"; |
There was a problem hiding this comment.
Same here. You should use PascalCase for the name after the dot.
|
|
||
|
|
||
| export class TodoItem extends Component { | ||
| static template = "awesome_owl.todo.item"; |
There was a problem hiding this comment.
| static template = "awesome_owl.todo.item"; | |
| static template = "awesome_owl.TodoItem"; |
|
|
||
|
|
||
| export class TodoList extends Component { | ||
| static template = "awesome_owl.todo.list"; |
There was a problem hiding this comment.
| static template = "awesome_owl.todo.list"; | |
| static template = "awesome_owl.TodoList"; |
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <templates xml:space="preserve"> | |||
| <t t-name="awesome_owl.todo.list"> | |||
| import { mountComponent } from "@web/env"; | ||
| import { Playground } from "./playground"; | ||
|
|
||
|
|
There was a problem hiding this comment.
That diff is not necessary 😃. We try to do as little change as possible as It can generate a big PR and it can make it complicate to read and understand.
| import { Component } from "@odoo/owl"; | ||
|
|
||
| export class Playground extends Component { | ||
| static template = "awesome_owl.playground"; |
There was a problem hiding this comment.
They should have used PascalCase 😢. No need to change that.
3 participants
No description provided.