[ADD] estate: created estate module #1022

danal-odoo · 2025-11-11T08:21:13Z

estate module
Create new module estate module for manage estate property with feature like create new property manage buy and sell with usererror and database constraint to reduce miss matched data to be enter in DB.
Awesome OWL
Create Card, Counter and Todo component.
Awesome Dashboard
add customers and leads button in layout and added dynamic card layout to render items with chartcard and numbercard. dashboard data will be refresh every 10 mins and added lazyloading to Dashboard.

robodoo · 2025-11-11T08:21:16Z

bit-odoo

Hello!
Nice work.
i have added some comments please have a look.

Can you please adapt your commit message and you need to add PR title and description.

you can take reference from here for commit message and title :- https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#commit-message-full-description

estate/__manifest__.py

bit-odoo · 2025-11-14T05:51:47Z

estate/models/estate_property.py

@@ -0,0 +1,78 @@
+#!/usr/bin/env python3


It is not necessary to add.

estate/security/ir.model.access.csv

estate/views/estate_menus.xml

estate/views/estate_property_views.xml

bit-odoo

Hello,
I have added some comments.

Can you please adapt your commit messages as I informed you in the first review?

estate/models/estate_property_offer.py

estate/models/estate_property.py

estate/__manifest__.py

estate/models/estate_property.py

bit-odoo · 2025-11-20T07:48:04Z

Hello @danal-odoo
I already informed you twice, but you haven't changed your commit message and PR title.

Can you please explain it to me why you push a separate commit for this type of changes?
Like this - 1a3bc65, cc1dabd

added estate module. created __init__.py and __manifest__.py files.

created estate property model. added all required fields in model.

added security CSV file in security folder. added estate_property model access to user in csv file.

added action view in estate property. created menuitems and linked action to that menuitems. updated manifest file to link all created file.

implemented form in views and added model fields in estate_property model. modified views and menuitem names.

…ality. added estate property form and list view. added search with filter and group_by functionality.

added estate_property_offer model and created required fields. added estate_property_tag model and created required fields. added estate_property_type model and created required fields. added models acces to user.

added @api.depends() decorator to calculate total area and best prrice. added @api.onchange() decorator to auto fill garden_area and orientation on garden change.

added action method on sold and cancel button. added UserError() to prevent sold property to cancel. added UserError() to prevent cancelled property to be sold.

…er view [FIX] estate: code formatting and rename compute method Improved code readability by applying consistent formatting. Renamed compute method for best_price to follow naming conventions. changed discription position after name in manifest file.

added stat button in property type to show quick offer list. added inline views in property types to get related fields from other model. added order method in models, views, manual. improved some logic in percentage calculation. code formation.

added python inheritance, model inheritance, view inheritance. added create function to change state from 'new' to 'offer_received'. separated all property action to it's own views file.

created Estate Account module and necessary files. added invoicing functionality by using inherit method. added UserError on sold button if no offer are accepted.

added kanban view in property default group by types. fixed state button to show offers in number with proper format. added option attr to all numerical field to prevent user error. added group by state in search.

… component. added counter button and component in playground xml. created counter and card component with it's xml and js files. added property field in sales order form using inheritance.

added markup() to render html element from component. added props validation in content in Card component. added calculateSum function to calculate sum of counter.

added todo component and created todolist and todoitem. created function to add todo item by user. fixed layout to be look more organize.

created todo component and in that component created todoitem and todolist. added todoitem in todolist to get all created todoitem with todolist using props. added todolist in playground.js to render all todolist. made card component dynamic by using slots prop by seting type to object. added card toogle button to show card content or not. made offer action button invisible if one offer is accepted.

added layout component in dashboard.js. created dashboard.scss to use className in xml. added display prop in layout.

added customers and leads button in controlpanel layout. linked onclick in button function to call view action for customers and leads.

bit-odoo

Hello,
I have added some suggestions.

bit-odoo · 2025-11-25T10:37:46Z

awesome_dashboard/static/src/dashboard.xml

@@ -1,8 +1,47 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <templates xml:space="preserve">
-


unneccary diff.

bit-odoo · 2025-11-25T10:38:02Z

awesome_dashboard/static/src/dashboard.xml

+            </div>
+        </Layout>
    </t>
-


unneccary diff.

bit-odoo · 2025-11-25T10:39:07Z

awesome_owl/static/src/counter/counter.js

+
+    increment() {
+        this.state.value++;
+        if (this.props.onChange){


Suggested change

if (this.props.onChange){

if (this.props.onChange) {

bit-odoo · 2025-11-25T10:39:41Z

awesome_owl/static/src/playground.js

+    }
+
+    calculateSum(newValue) {
+        if (newValue > 0){


Suggested change

if (newValue > 0){

if (newValue > 0) {

bit-odoo · 2025-11-25T10:39:52Z

awesome_owl/static/src/playground.js

+        if (newValue > 0){
+            this.state.sum++;
+        }   
+        if (newValue < 0){


Suggested change

if (newValue < 0){

if (newValue < 0) {

bit-odoo · 2025-11-25T10:40:10Z

awesome_owl/static/src/playground.xml

@@ -1,10 +1,41 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <templates xml:space="preserve">
-


unneccary diff.

bit-odoo · 2025-11-25T10:40:21Z

awesome_owl/static/src/playground.xml

+            </Card>
        </div>
    </t>
-


unneccary diff.

bit-odoo · 2025-11-25T10:41:21Z

awesome_owl/static/src/todo/todoitem.js

+        removeTodo: Function
+    };
+
+    toggleIsCompleted(){


Suggested change

toggleIsCompleted(){

toggleIsCompleted() {

bit-odoo · 2025-11-25T10:42:26Z

awesome_owl/static/src/todo/todolist.js

+        todo.isCompleted = !todo.isCompleted;
+    }
+
+    removeTodo(id){


Suggested change

removeTodo(id){

removeTodo(id) {

bit-odoo · 2025-11-25T10:42:39Z

awesome_owl/static/src/todo/todolist.js

+
+    removeTodo(id){
+        const index = this.todos.findIndex((elem) => elem.id === id);
+        if (index >= 0){


Suggested change

if (index >= 0){

if (index >= 0) {

bit-odoo · 2025-11-25T10:57:33Z

estate/models/estate_property.py

+    _check_expected_price = models.Constraint(
+        "CHECK(expected_price > 0)",
+        "A property expected price must be strictly positive.",
+    )
+    _check_selling_price = models.Constraint(
+        "CHECK(selling_price >= 0)", "A property selling price must be positive."
+    )


It is good that we can declare it after the fields.

bit-odoo · 2025-11-25T11:03:41Z

estate/models/estate_property.py

+        self.garden_area = 10
+        self.garden_orientation = "north"
+        if not self.garden:


Why multiple times change the value if the garden is not true?. It is unnecessarily writing a value.

Can you please explain it to me?

so i used inverse condition to avoid use of else in this function but now i understand my mistake if i don't use else then it will first store garden_area = 10 and then orientation = "north" every time this onchange function is called so i have to use if else condition to avoid extra db write.

Why do you want to avoid the else condition?. Could you please explain it?

to reduce check condition and make code faster

Is else reduce performance? I don't think it is right.
Currently, your code causes performance issues.

Can you please elaborate properly? So I can understand your thought.

yes sir current code is causing performance issue cause it is writing 2 fields without any reason those extra write can give huge impact on busy server and i totally forgot about that performance issue in db i focused on making current function more optimized but it was not space efficient and in db it is very important to use every ORM carefully to reduce impact on dbservers i have revert back to my original optimized logic to fix performance issue.

Can you please explain to me what you wrote here #1022 (comment)
make code faster.

How else cause the performance issue?

like it will not check if condition first then it is false and then run else instead it will directly assign garden_area = 10 and orientation to "north" cause at first garden is by default false so second condition will not run but will cause issue when garden change from True to False it will rewrite those true condition again so will query 4 time after change of garden so yes it is not faster.

Can you please explain to me what you wrote here #1022 (comment) make code faster.

How else cause the performance issue?

no sir, else does not reduce performance and it was my mistake to remove else. infect in this case it increase performance by reducing db query.

added DashboardItem component. added slot props in DashboardItem and created a dynamic card in xml. added rpc call in onWillStart(). render all return values in it's separate card in dashboard.xml. added state as 'badge' widget in kanban view in estate module. refined garden onchange logic.

created service to load rpc call and load rpc data. added interval for rpc call to refresh data every 10 minuets. added Chart to show t-shirt size in chart view. load dashboard as lazy-loading by register that Component to lazy-components.

added a settings icon near Dashboard in Layout component. added popup form to select which item to show/hide in Dashboard. added function which will store those settings in Browser's local storage.

added onchange on offer_ids if len(offer_ids) is zero then will change state to 'new'. fixed state button layout was in header first shifted to context menu. added sold button disabled when there is no offer accepted and if offer is accepted then will show in highlight color.

danal-odoo marked this pull request as draft November 13, 2025 12:30

danal-odoo force-pushed the 19.0-tutorial-danal branch 2 times, most recently from 89b75bc to dddb04b Compare November 13, 2025 13:44

bit-odoo reviewed Nov 14, 2025

View reviewed changes

danal-odoo changed the title ~~19.0 tutorial danal~~ [ADD] estate: Created new module Nov 14, 2025

danal-odoo changed the title ~~[ADD] estate: Created new module~~ [ADD] estate: created new module Nov 14, 2025

danal-odoo force-pushed the 19.0-tutorial-danal branch from dddb04b to 63624e0 Compare November 14, 2025 10:34

bit-odoo reviewed Nov 15, 2025

View reviewed changes

danal-odoo force-pushed the 19.0-tutorial-danal branch from d90aff1 to 52a72e8 Compare November 15, 2025 07:47

danal-odoo changed the title ~~[ADD] estate: created new module~~ created estate module Nov 15, 2025

danal-odoo force-pushed the 19.0-tutorial-danal branch 3 times, most recently from e9fbfd7 to d1e1228 Compare November 18, 2025 18:03

danal-odoo force-pushed the 19.0-tutorial-danal branch from 1516839 to 081eea5 Compare November 20, 2025 08:14

danal-odoo added 14 commits November 20, 2025 14:26

[ADD] estate: created estate application and important files.

d39b681

added estate module. created __init__.py and __manifest__.py files.

[IMP] estate: created models for estate application.

c1b9539

created estate property model. added all required fields in model.

[IMP] estate: implimented security for model access.

eb9e8d3

added security CSV file in security folder. added estate_property model access to user in csv file.

[IMP] estate: created views, menuitem and modified manifest file.

0c74148

added action view in estate property. created menuitems and linked action to that menuitems. updated manifest file to link all created file.

[IMP] estate: implemented form and model fields, code formation.

dfeb5ac

implemented form in views and added model fields in estate_property model. modified views and menuitem names.

[IMP] estate: added form and search with Filter and Group By function…

b8d60d4

…ality. added estate property form and list view. added search with filter and group_by functionality.

[IMP] estate: added offer, tag and type models and created views.

b3387a8

added estate_property_offer model and created required fields. added estate_property_tag model and created required fields. added estate_property_type model and created required fields. added models acces to user.

[IMP] estate: add compute, inverse and on chnage in estate offer model.

8013e8d

added @api.depends() decorator to calculate total area and best prrice. added @api.onchange() decorator to auto fill garden_area and orientation on garden change.

[IMP] estate: added restrictions and action in property offer.

7519102

added action method on sold and cancel button. added UserError() to prevent sold property to cancel. added UserError() to prevent cancelled property to be sold.

[IMP] estate: added inheritance and on create functions.

6098504

added python inheritance, model inheritance, view inheritance. added create function to change state from 'new' to 'offer_received'. separated all property action to it's own views file.

[ADD] estate: added Estate Account Module

d5c1168

created Estate Account module and necessary files. added invoicing functionality by using inherit method. added UserError on sold button if no offer are accepted.

[IMP] estate: added kanban view and optimized offer state button

cf8dd0a

added kanban view in property default group by types. fixed state button to show offers in number with proper format. added option attr to all numerical field to prevent user error. added group by state in search.

danal-odoo added 3 commits November 20, 2025 14:34

[IMP] estate: code formation as per odoo guidline

b10034f

[IMP] awesome_owl: added counter ui in playground, added card,counter…

faedfa7

… component. added counter button and component in playground xml. created counter and card component with it's xml and js files. added property field in sales order form using inheritance.

[IMP] awesome_owl: added markup(),props validation, sum counter

ff459f4

added markup() to render html element from component. added props validation in content in Card component. added calculateSum function to calculate sum of counter.

danal-odoo force-pushed the 19.0-tutorial-danal branch from 081eea5 to ff459f4 Compare November 20, 2025 09:04

danal-odoo changed the title ~~created estate module~~ [ADD] estate: created estate module Nov 20, 2025

danal-odoo added 4 commits November 21, 2025 10:12

[IMP] awesome_owl: added todo component.

35610bc

added todo component and created todolist and todoitem. created function to add todo item by user. fixed layout to be look more organize.

[IMP] awesome_dashboard: added layout component in dashboard.

12ab960

added layout component in dashboard.js. created dashboard.scss to use className in xml. added display prop in layout.

[IMP] awesome_dashboard: added customers and leads button.

8c73677

added customers and leads button in controlpanel layout. linked onclick in button function to call view action for customers and leads.

bit-odoo reviewed Nov 25, 2025

View reviewed changes

danal-odoo force-pushed the 19.0-tutorial-danal branch from 1cb7a42 to a7b2f9e Compare November 25, 2025 10:55

bit-odoo reviewed Nov 25, 2025

View reviewed changes

danal-odoo force-pushed the 19.0-tutorial-danal branch from a7b2f9e to 86496fb Compare November 25, 2025 11:42

danal-odoo force-pushed the 19.0-tutorial-danal branch from 86496fb to ced1c9f Compare November 25, 2025 11:52

danal-odoo added 2 commits November 27, 2025 10:55

[IMP] awesome_dashboard: added popup to select item to show/hide.

38cc6e5

added a settings icon near Dashboard in Layout component. added popup form to select which item to show/hide in Dashboard. added function which will store those settings in Browser's local storage.

danal-odoo force-pushed the 19.0-tutorial-danal branch from 77277ba to 38cc6e5 Compare November 27, 2025 11:03

danal-odoo force-pushed the 19.0-tutorial-danal branch from 3733b88 to 5d27874 Compare November 28, 2025 05:51

		@@ -1,8 +1,47 @@
		<?xml version="1.0" encoding="UTF-8" ?>
		<templates xml:space="preserve">

		@@ -1,10 +1,41 @@
		<?xml version="1.0" encoding="UTF-8" ?>
		<templates xml:space="preserve">

[ADD] estate: created estate module #1022

Are you sure you want to change the base?

[ADD] estate: created estate module #1022

Uh oh!

Conversation

danal-odoo commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Nov 11, 2025

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bit-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bit-odoo commented Nov 20, 2025

Uh oh!

bit-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

danal-odoo commented Nov 11, 2025 •

edited

Loading

bit-odoo left a comment •

edited

Loading

bit-odoo left a comment •

edited

Loading