leker - Technical training #1063
Open
+234
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amah-odoo
reviewed
Dec 15, 2025
amah-odoo
left a comment
amah-odoo
left a comment
There was a problem hiding this comment.
Nice work 💪🏼
Let's go with your first review 🎉
estate/models/estate_property.py
Outdated
Comment on lines
20
to
21
| garden_orientation = fields.Selection(string='Garden Orientation', | ||
| selection=[('north', 'North'), ('south', 'South'), ('est', 'Est'), ('west', 'West')]) |
There was a problem hiding this comment.
I prefer that way to be more readable for the selection fields
Suggested change
| garden_orientation = fields.Selection(string='Garden Orientation', | |
| selection=[('north', 'North'), ('south', 'South'), ('est', 'Est'), ('west', 'West')]) | |
| garden_orientation = fields.Selection([ | |
| ('north', 'North'), | |
| ('south', 'South'), | |
| ('east', 'East'), | |
| ('west', 'West') | |
| ], string='Garden Orientation',) |
estate/__manifest__.py
Outdated
Comment on lines
1
to
6
| {'name': 'Real Estate', | ||
| 'depends': ['base'], | ||
| 'application': True, | ||
| 'author': 'leker', | ||
| 'license': 'LGPL-3', | ||
| } |
There was a problem hiding this comment.
let's go with this format 👀
Suggested change
| {'name': 'Real Estate', | |
| 'depends': ['base'], | |
| 'application': True, | |
| 'author': 'leker', | |
| 'license': 'LGPL-3', | |
| } | |
| { | |
| 'name': 'Real Estate', | |
| 'depends': ['base'], | |
| 'application': True, | |
| 'author': 'leker', | |
| 'license': 'LGPL-3', | |
| } |
lkerroum
force-pushed
the
master-tutorial-server-leker
branch
from
db23143 to
37fd581
Compare
lkerroum
force-pushed
the
master-tutorial-server-leker
branch
from
37fd581 to
cb5ea91
Compare
…ype, salesperson, buyer
amah-odoo
reviewed
Dec 18, 2025
Comment on lines
4
to
6
| 'data': ['security/ir.model.access.csv', | ||
| 'views/estate_property_views.xml', | ||
| 'views/estate_menus.xml'], |
There was a problem hiding this comment.
let's be coherent with the rest of odoo modules 👀
Suggested change
| 'data': ['security/ir.model.access.csv', | |
| 'views/estate_property_views.xml', | |
| 'views/estate_menus.xml'], | |
| 'data': [ | |
| 'security/ir.model.access.csv', | |
| 'views/estate_property_views.xml', | |
| 'views/estate_menus.xml' | |
| ], |
| 'views/estate_property_views.xml', | ||
| 'views/estate_menus.xml'], | ||
| 'application': True, | ||
| 'author': 'leker', |
There was a problem hiding this comment.
The author is always 'Odoo S.A.' for the RD because to develop for odoo it is not out own apps 🤔
| <field name="res_model">estate.property</field> | ||
| <field name="view_mode">list,form</field> | ||
| </record> | ||
| </odoo> No newline at end of file |
There was a problem hiding this comment.
Do not forget to add the end of file empty line
| </list> | ||
| </field> | ||
| </record> | ||
| </odoo> No newline at end of file |
Comment on lines
+1
to
+6
| from . import ( | ||
| estate_property, | ||
| estate_property_offer, | ||
| estate_property_tag, | ||
| estate_property_type, | ||
| ) |
There was a problem hiding this comment.
I know that Ruff is happy with that but we actually prefer to have each import on its own line like
from . import estate_property
from . import estate_property_offer
...| <menuitem id="property_tags_model_menu_action" action="estate_property_tag_action"/> | ||
| </menuitem> | ||
| </menuitem> | ||
| </odoo> No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.