real estate module (ibmah) #1069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amah-odoo
reviewed
Dec 16, 2025
estate/__manifest__.py
Outdated
| 'name': "estate", | ||
| 'version': '1.0', | ||
| 'depends': ['base'], | ||
| 'author': "ibrahim (ibmah)", |
There was a problem hiding this comment.
The author is always 'Odoo S.A.' for the RD because to develop for odoo it is not out own apps 🤔
estate/models/estate_property.py
Outdated
| ('east', 'East'), | ||
| ('west', 'West')], | ||
| help = 'Indicates the direction the garden is facing with respect to the house') | ||
|
|
There was a problem hiding this comment.
we tend to leave only 1 line at the end of the file
estate/models/estate_property.py
Outdated
Comment on lines
18
to
22
| garden_orientation = fields.Selection( | ||
| selection=[('north', 'North'), | ||
| ('south', 'South'), | ||
| ('east', 'East'), | ||
| ('west', 'West')], |
There was a problem hiding this comment.
A personal pref but want to show another way to structure this
Suggested change
| garden_orientation = fields.Selection( | |
| selection=[('north', 'North'), | |
| ('south', 'South'), | |
| ('east', 'East'), | |
| ('west', 'West')], | |
| garden_orientation = fields.Selection([ | |
| ('north', 'North'), | |
| ('south', 'South'), | |
| ('east', 'East'), | |
| ('west', 'West') | |
| ], help = "put it here") |
ibmah-odoo
force-pushed
the
master-real-estate-ibmah
branch
from
19f4418 to
078c9bb
Compare
amah-odoo
reviewed
Dec 16, 2025
amah-odoo
left a comment
amah-odoo
left a comment
There was a problem hiding this comment.
This is mainly about the commit msg let's try working to have the chapter number in the commit header (commit first line) and I want you to add some description for each commit body with what is done in this chapter
.gitignore
Outdated
|
|
||
| # Pyre type checker | ||
| .pyre/ | ||
| pyrightconfig.json |
There was a problem hiding this comment.
do not add your own .gitignore to the commits
ibmah-odoo
force-pushed
the
master-real-estate-ibmah
branch
2 times, most recently
from
bcec691 to
20f7abf
Compare
ibmah-odoo
force-pushed
the
master-real-estate-ibmah
branch
from
20f7abf to
81cede7
Compare
Chapter 7 This adds tags to properties, lists offers made (whether refued or accepted) along with the salesperson and buyer in "Other info" tab
ibmah-odoo
force-pushed
the
master-real-estate-ibmah
branch
from
81cede7 to
a2ae3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1062. This one is based on master instead of v19.0