Master technical onboarding faavc #1071
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Creating the manifest file.
New ir.model.access file to adding all kind of accesses to the base.group_user and connecting csv file to manifest [LINT] estate: fixing linter issues [LINT] estate: adding new lines to the end of the few file
[LINT] estate: linting all python files with ruff
…hapter 6 add: state field to the estate_property model security: readonly and all-rights security groups are created views: list, form, search views are created, in search view state filter and postcode groupby features are added manifest is updated with the security file
new models: estate_property_offer, estate_property_tag estate_property: adding new fields (type, salesperson, buyer, tags, offers) estate_property_view: adding offers to form view, tags to both list and form views estate_property_offer_view: adding list and form views menu: settings menu for types and tags
computed fields: deadline of the offer, best price from many offers onchange: garden affects garden_area and garden_orientation
…ffers - Chapter 9 estate_property: adding cancel and sold buttons and actions for those buttons estate_property_offer: adding accept and refuse buttons and actions for those buttons learned: actions, exception example, icons in buttons
Faruk372742
force-pushed
the
master-technical_onboarding-faavc
branch
from
0b0c858 to
79ff504
Compare
SQL constraints: expected_price, selling_price, offer price, property tag and type Python constraints: selling price >= 0.9 of the expected price
amah-odoo
reviewed
Dec 18, 2025
amah-odoo
left a comment
amah-odoo
left a comment
There was a problem hiding this comment.
Huge work so far 🎉
just small comment for now
estate/models/estate_property.py
Outdated
| garden = fields.Boolean() | ||
| garden_area = fields.Integer() | ||
| garden_orientation = fields.Selection(string="Orientation", selection=[("North", "North"), ("South", "South"), ("East", "East"), ("West", "West")]) | ||
|
No newline at end of file |
There was a problem hiding this comment.
do not forget the new line at the end of file
estate/models/estate_property.py
Outdated
| garage = fields.Boolean() | ||
| garden = fields.Boolean() | ||
| garden_area = fields.Integer() | ||
| garden_orientation = fields.Selection(string="Orientation", selection=[("North", "North"), ("South", "South"), ("East", "East"), ("West", "West")]) |
There was a problem hiding this comment.
I would prefer to right the selection options that way to make it more clearer Also the tuple first value represent the technical name so it should be in snake_case 🐍
Suggested change
| garden_orientation = fields.Selection(string="Orientation", selection=[("North", "North"), ("South", "South"), ("East", "East"), ("West", "West")]) | |
| garden_orientation = fields.Selection([ | |
| ("north", "North"), | |
| ("south", "South"), | |
| ("east", "East"), | |
| ("west", "West") | |
| ], string="Orientation") |
estate/models/estate_property.py
Outdated
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Date( | ||
| copy=False, default=datetime.now() + relativedelta(months=3) |
There was a problem hiding this comment.
for the default values it is get evaluated on server boot-up So without the lambda once you run the server it will take the date and after 1 week if you created new property it will take the 3 month from the server boot-up not 3 month from real today.
Suggested change
| copy=False, default=datetime.now() + relativedelta(months=3) | |
| copy=False, default=lambda self: datetime.now() + relativedelta(months=3) |
estate/models/estate_property.py
Outdated
| buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False) | ||
| tag_ids = fields.Many2many("estate_property_tag") | ||
| offer_ids = fields.One2many("estate_property_offer", "property_id", string="Offers") | ||
| total_area = fields.Integer("Total Area (sqm)", compute="_compute_area") |
There was a problem hiding this comment.
for compute method we tend to use the full field name if it is the only field computed in the method
Suggested change
| total_area = fields.Integer("Total Area (sqm)", compute="_compute_area") | |
| total_area = fields.Integer("Total Area (sqm)", compute="_compute_total_area") |
estate/models/estate_property.py
Outdated
Comment on lines
66
to
70
| record.best_price = ( | ||
| 0 | ||
| if len(record.offer_ids) == 0 | ||
| else max(offer.price for offer in record.offer_ids) | ||
| ) |
There was a problem hiding this comment.
the .mapped('field') return a list with the all the field values for the recordset and the or [0] will replace the list of prices with list contain 0 if the list is empty list
Suggested change
| record.best_price = ( | |
| 0 | |
| if len(record.offer_ids) == 0 | |
| else max(offer.price for offer in record.offer_ids) | |
| ) | |
| record.best_price = max(record.offer_ids.mapped('price') or [0]) |
ref: maximizing method and name of the computation method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.