[FIX] util/pg: drop indexes when removing constraints #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
If a constraint with the same name was found. Attempt as well to drop any existing index with the same name. Otherwise we may leave behind constraints implemented as unique indexes. See odoo/upgrade#8318
aj-fuentes
force-pushed
the
master-fix_drop_indexes-afu
branch
from
033f232 to
34c3c1f
Compare
Contributor
Author
|
upgradeci retry with always base account_edi_proxy_client |
Contributor
|
upgradeci retry with always only base account_edi_proxy_client |
Contributor
|
It's not needed. The
|
Contributor
Author
In stable we create indexes in auto_init. Supposedly with this name format. I guess they are not associated to the constraint directly at PG level. |
Contributor
|
And it also won't work for partial indexes. |
KangOl
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a constraint with the same name was found. Attempt as well to drop
any existing index with the same name. Otherwise we may leave behind
constraints implemented as unique indexes.
See odoo/upgrade#8318