Skip to content

[FIX] util/pg: drop indexes when removing constraints #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FIX] util/pg: drop indexes when removing constraints #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/util/pg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,15 +795,17 @@ def remove_constraint(cr, table, name, cascade=False, warn=True):
"""
_validate_table(table)
log = _logger.warning if warn else _logger.info
cascade = "CASCADE" if cascade else ""
cr.execute('ALTER TABLE "{}" DROP CONSTRAINT IF EXISTS "{}" {}'.format(table, name, cascade))
cascade = SQLStr("CASCADE" if cascade else "")
cr.execute(format_query(cr, "ALTER TABLE {} DROP CONSTRAINT IF EXISTS {} {}", table, name, cascade))
# Exceptionally remove Odoo records, even if we are in PG land on this file. This is somehow
# valid because ir.model.constraint are ORM low-level objects that relate directly to table
# constraints.
cr.execute("DELETE FROM ir_model_constraint WHERE name = %s RETURNING id", [name])
if cr.rowcount:
ids = tuple(c for (c,) in cr.fetchall())
cr.execute("DELETE FROM ir_model_data WHERE model = 'ir.model.constraint' AND res_id IN %s", [ids])
# The constraint was found remove any index with same name
cr.execute(format_query(cr, "DROP INDEX IF EXISTS {}", name))
return True
if name.startswith(table + "_"):
log("%r not found in ir_model_constraint, table=%r", name, table)
Expand Down