[IMP] orm: add option to iter_browse for yielding chunks #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
Can you add a test? upgradeci retry with always only base |
cawo-odoo
force-pushed
the
master-imp_iter_browse_yield_chunks-cawo
branch
from
f94d79f to
b38c54d
Compare
The `iter_browse` class already loads records in chunks, but the iterator returned by `__iter__` always yields single records. Here we add a flag to the constructor (default `False`) that when set to `True` will make `__iter__` return an iterator that yields chunks of the same size as it is loading (i.e. `chunk_size`).
cawo-odoo
force-pushed
the
master-imp_iter_browse_yield_chunks-cawo
branch
from
b38c54d to
a017851
Compare
aj-fuentes
approved these changes
Dec 3, 2025
KangOl
approved these changes
Dec 4, 2025
Contributor
|
I'm sorry, @KangOl. I'm afraid I can't do that. |
Contributor
|
robodoo r+ |
Contributor
|
@cawo-odoo @nseinlet linked pull request(s) odoo/upgrade#8987 not ready. Linked PRs are not staged until all of them are ready. |
robodoo
pushed a commit
that referenced
this pull request
Dec 4, 2025
The `iter_browse` class already loads records in chunks, but the iterator returned by `__iter__` always yields single records. Here we add a flag to the constructor (default `False`) that when set to `True` will make `__iter__` return an iterator that yields chunks of the same size as it is loading (i.e. `chunk_size`). closes #362 Related: odoo/upgrade#8987 Signed-off-by: Nicolas Seinlet (nse) <nse@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iter_browseclass already loads records in chunks, but the iterator returned by__iter__always yields single records. Here we add a flag to the constructor (defaultFalse) that when set toTruewill make__iter__return an iterator that yields chunks of the same size as it is loading (i.e.chunk_size).