Added starting items to /matches endpoint #2254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardchung
reviewed
Oct 15, 2020
processors/processLogParse.js
Outdated
| function processReduce(entries, meta) { | ||
| const result = entries.filter((e) => { | ||
| if (e.type === 'DOTA_COMBATLOG_PURCHASE' | ||
| if (e.type === 'DOTA_COMBATLOG_PURCHASE' || e.type === 'STARTING_ITEM' |
Member
There was a problem hiding this comment.
I think we can leave this out, we don't need this in the pro game logs.
howardchung
approved these changes
Oct 25, 2020
Member
|
This looks generally fine, but we might want to optimize how we store this data, as we'd be storing this x10 players for each match and storage is already the most expensive part of running the service. |
Member
|
This will need a rebase if it still should be merged, and the processor code is now in odota/parser. If possible I'd also like to see an example of how this looks/changes the parser blob output so we can estimate the storage impact |
Contributor
Author
|
I'm not sure this is necessary anymore. It is currently possible to get a players starting items by checking the players purchase_log and the purchase time <= 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odota/parser#42