Rollback database transactions when inserts or updates fail#2956
Merged
howardchung merged 2 commits intoodota:masterfrom May 9, 2026
Merged
Rollback database transactions when inserts or updates fail#2956howardchung merged 2 commits intoodota:masterfrom
howardchung merged 2 commits intoodota:masterfrom
Conversation
If work after db.transaction() throws, release the client with rollback before rethrowing so the pool is not left with an open transaction. Co-authored-by: Cursor <cursoragent@cursor.com>
Mirror insertMatch behavior so exceptions after db.transaction() always call trx.rollback() before propagating. Co-authored-by: Cursor <cursoragent@cursor.com>
howardchung
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
If match inserts (
insertMatch), rating updates (rater), or Stripe subscriber sync (syncSubs) throw after starting a transaction, we now roll back that transaction before the error propagates.Why
Without an explicit rollback, a failed path can leave Postgres sessions stuck in a bad transaction state and tie up pool connections.