Ignore unused items that are whitelisted or purchased at the end of a game#1286
Merged
Conversation
howardchung
approved these changes
Oct 31, 2017
Member
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #974
First off, thanks for all your work in making such an awesome site, I've been using it for the past few years and it's made accessing and viewing all my dota stats much easier and enjoyable.
I've done a little bit of work to address #974 .
The only thing I'm uncertain about is the format of times for events in the game log, should I assume that they are in seconds?
I'm quite happy to make any changes needed. I'm fairly new to contributing so any feedback/improvements are more than welcome!