Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unused items that are whitelisted or purchased at the end of a game #1286

Merged
merged 3 commits into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@nchlswhttkr
Copy link
Contributor

commented Oct 31, 2017

fixes #974

First off, thanks for all your work in making such an awesome site, I've been using it for the past few years and it's made accessing and viewing all my dota stats much easier and enjoyable.

I've done a little bit of work to address #974 .

The only thing I'm uncertain about is the format of times for events in the game log, should I assume that they are in seconds?

I'm quite happy to make any changes needed. I'm fairly new to contributing so any feedback/improvements are more than welcome!

@howardchung

This comment has been minimized.

Copy link
Member

commented Oct 31, 2017

LGTM

@howardchung howardchung merged commit 2d2c92e into odota:master Nov 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@howardchung howardchung referenced this pull request Nov 9, 2017

Merged

[RELEASE] 2017-11-08 #1303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.