Add tooltips to Records page #1814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardchung
reviewed
Sep 20, 2018
Contributor
Author
|
@howardchung Changes made, let me know if there's anything else |
howardchung
approved these changes
Sep 21, 2018
Member
|
LGTM I was actually thinking about removing the records page since it gets very little use and the nav bar is getting cluttered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses issue #1342, specifically this comment.
I enable the TabBar component to show tooltips, if a tooltip is provided. I then add tooltips to the tabs on the "Records" page (i.e. "K", "D", "A", "GPM", "XPM", ...).
I'm a newbie to React -- let me know if anything looks fishy. Cheers.