2832 - Combo Page aria labels#2853
Merged
howardchung merged 1 commit intoodota:masterfrom Oct 18, 2021
Merged
Conversation
micahchiang
commented
Oct 16, 2021
| opacity: 0.5; | ||
| cursor: pointer; | ||
| margin-left: 10px; | ||
| outline: none; |
Contributor
Author
There was a problem hiding this comment.
Removed this because it is keyboard focusable and should provide visual feedback when focused.
howardchung
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds aria labels to these elements on the Combo page: Hero Filter, Reset Btn, team select buttons. This is needed because screen reader users currently have no context around what these elements do. As seen in attached screenshots, screen readers will read out ambiguous labels. With these fixes, screen readers provide more understandable context around what each element actually does.
Current VoiceOver readout
VoiceOver readout with proposed fix