refactor: extract conference provider interface for Meet and Teams#9
Merged
Conversation
Separate platform-specific DOM knowledge (JS expressions, JSON parsing) from the speaker detection state machine (CSS class discovery, cached polling). - `internal/conference/` defines `Provider` interface with 6 methods - `internal/conference/meet/` implements Meet-specific extraction - `internal/conference/teams/` implements Teams-specific extraction - Detector becomes a pure orchestrator consuming injected providers - CSS class validation moves into each provider's PollExpression - 95% test coverage on providers, 93% on detector state machine
- Enable revive exported lint with stutter and private-receiver checks - Add godoc to exported symbols across internal packages - Rename config.ConfigDir → config.Dir and segment.SegmentHandler → segment.Handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/speaker/intointernal/conference/{meet,teams}packagesconference.Providerinterface with 6 methods:Name,MatchesURL,SnapshotExpression,ParseSnapshot,PollExpression,ParsePollPollExpressionmethodexportedlint rule and adds godoc comments across internal packagesTest plan
mise run buildpasses (lint, test, tidy, diff)var _ signals.SpeakerPoller = (*speaker.Detector)(nil))