Fix multiclass LinearSVC fallback paths (closes #256)#345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #256 reports multiclass
LinearSVCfailing in dashboard/explainer flows because it typically exposesdecision_functionbut notpredict_proba. Existing code paths assumedpredict_proba, which caused:AttributeError)What Changed
predict_probawhen validdecision_functionand converts scores to probabilities (sigmoid for binary, softmax for multiclass)ClassifierExplainerprediction and kernel-SHAP callback pathsget_pdp_df)Tests
Added regression tests for multiclass
LinearSVC:Added guard tests for multiclass logistic regression to ensure existing
predict_probabehavior remains unchanged.Release Notes
Updated
RELEASE_NOTES.mdunder0.5.8with issue#256fixes and coverage.Validation Run
uv run pytest -q tests/test_linear_model.pyuv run ruff check explainerdashboard/explainer_methods.py explainerdashboard/explainers.py tests/test_linear_model.pyCloses #256